GAM icon indicating copy to clipboard operation
GAM copied to clipboard

Support for fish shell

Open iMonZ opened this issue 1 year ago • 7 comments

Support for the fish shell in the installation and after the setup is finished. The commands that are provided to set everything up do not work in this shell.

iMonZ avatar Jun 07 '24 09:06 iMonZ

Send me a Meet/Zoom invitation and I'll try to help.

Ross

Ross Scroggs @.***

On Jun 7, 2024, at 2:35 AM, Max Vincent Goldgamer @.***> wrote:

Support for the fish shell in the installation and after the setup is finished. The commands that are provided to set everything up do not work in this shell.

— Reply to this email directly, view it on GitHub https://github.com/GAM-team/GAM/issues/1691, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCTYL52KP2EF5XUC2BR5BLZGF5FNAVCNFSM6AAAAABI6KDCU2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DAMBRGQ2DIMA. You are receiving this because you are subscribed to this thread.

taers232c avatar Jun 07 '24 14:06 taers232c

Few points here:

  • Even if fish is the default shell Bash should be present on the system so the installer command bash <(curl... should "just work" on these systems. Creating an installer script that can be properly interpreted by multiple shells (bash, zsh, fish, whatever) is out of scope here.
  • If GAM is able to detect fish is default shell for user we may be able to update the fish rc file (~/.fishrc ?) with commands to tell fish how to execute GAM.

jay0lee avatar Oct 03 '24 09:10 jay0lee

@jay0lee it doesn't seem like your first point is accurate. Fish requires the use of psub:

bash (curl -s -S -L https://gam-shortn.appspot.com/gam-install | psub)

Attempting to use the standard bash redirection fails:

> bash <(curl -s -S -L https://gam-shortn.appspot.com/gam-install)
fish: Invalid redirection target:
bash <(curl -s -S -L https://gam-shortn.appspot.com/gam-install)

justindthomas avatar Apr 17 '25 22:04 justindthomas

Send me a Meet/Zoom invitation.

Ross

ross.scroggs @ gmail.com

taers232c avatar Apr 17 '25 23:04 taers232c

Thanks @taers232c - I think I'm set. GAM installed okay for me using that adjusted command.

justindthomas avatar Apr 17 '25 23:04 justindthomas

Old guy here, what is psub?

taers232c avatar Apr 17 '25 23:04 taers232c

It's a fish-specific mechanism for process substitution:

https://fishshell.com/docs/current/cmds/psub.html

As shells go, fish is pretty unique. I'm still getting used to it myself and trying to decide if the peculiarities are a benefit or a hindrance (I'm leaning toward the former).

justindthomas avatar Apr 17 '25 23:04 justindthomas