scikit-fda icon indicating copy to clipboard operation
scikit-fda copied to clipboard

Feature/fdm

Open E105D104U125 opened this issue 1 year ago • 1 comments

  • Added FDM feature in the dimensionality reduction submodule of the preprocessing module _fdm.py .
  • Included a test file for testing the new method test_fdm.py .
  • Created and added an example for the wiki plot_fdm.py .

E105D104U125 avatar Jul 09 '24 17:07 E105D104U125

Ignoring flake8 errors WPS440 and WPS441 in the doc example file plot_fdm .

E105D104U125 avatar Jul 09 '24 17:07 E105D104U125

Again, sorry for taking so long reviewing this. The main functionality is great, I just have a couple of nitpicks in documentation and tests.

If you do not have the time/will to do the changes, just tell me and I will apply them myself (but please, answer my question about the comparison in the tests, as I truly do not remember which was the reference package).

I implemented and pushed all changes. There is a problem with the style tests FileNotFoundError: [Errno 2] No such file or directory: 'examples/plot_fdm.py skfda/preprocessing/dim_reduction/__init__.py .

E105D104U125 avatar Mar 09 '25 16:03 E105D104U125

Also, I created a web version of the study that I did on the FDM method, FDM GitHub pages I was thinking it could be interesting to reference it in a note in the FDM class example of use. The website is essentially a more in depth version of the example of use notebook, including mathematical background and further experiments. Please let me know your view on this.

E105D104U125 avatar Mar 09 '25 16:03 E105D104U125

Also, I created a web version of the study that I did on the FDM method, FDM GitHub pages I was thinking it could be interesting to reference it in a note in the FDM class example of use. The website is essentially a more in depth version of the example of use notebook, including mathematical background and further experiments. Please let me know your view on this.

Hey, that is cool! Yes, you can add a note on the top pointing to that page, or just reference it with a footnote cite, also at the top of the page, so that nobody misses it.

vnmabus avatar Mar 09 '25 17:03 vnmabus

Thanks for the comments and suggestions. I will work on it in two weeks time, right now I'll be unable.

E105D104U125 avatar Mar 22 '25 15:03 E105D104U125

Sure! Take the time you need.

vnmabus avatar Mar 22 '25 15:03 vnmabus

At the end I found some free time and did the changes myself, as they where small. Thanks again for your contribution, I wish you luck with your current endeavors!

vnmabus avatar Mar 23 '25 15:03 vnmabus

@all-contributors add @E105D104U125 for code, documentation, tests, examples and research.

vnmabus avatar Mar 23 '25 15:03 vnmabus

@vnmabus

I've put up a pull request to add @E105D104U125! :tada:

allcontributors[bot] avatar Mar 23 '25 15:03 allcontributors[bot]

At the end I found some free time and did the changes myself, as they where small. Thanks again for your contribution, I wish you luck with your current endeavors!

Thanks for finishing things up @vnmabus. I wish you luck too!

E105D104U125 avatar Mar 23 '25 16:03 E105D104U125