python-odml icon indicating copy to clipboard operation
python-odml copied to clipboard

Published 20 hours ago • verified publisher icon G-Node

Move rdflib dependent code to own library

Open mpsonntag opened this issue 3 years ago • 8 comments

The rdflib library is required for conversion of odml to its RDF specific format. Since this library has caused multiple issues in the past and is still causing issues to this date it might be worth looking into moving RDF dependent code from the odml core library into a dedicated sub-library.

mpsonntag avatar Dec 06 '21 11:12 mpsonntag

Hi. May I ask what the plans are with regards to rdflib? Version 6.2.0 has landed in Fedora rawhide recently, breaking the build of odml. I noticed odml has the rdflib version pinned to 5.0.0. That would require a compat rdflib5 package in Fedora to satisfy odml's dependencies.

Before we embark on that endeavor I wanted to check with upstream (you) on plans for making odml work with rdflib >= 6.0.0.

penguinpee avatar Oct 14 '22 10:10 penguinpee

Hi @penguinpee, thank you for the comment! This issue has been on my todo list for quite a while now, but unfortunately I cannot say, when I will get around to addressing it as of yet. My plan would be to first fix the build with the latest RDFlib version available. This will probably require a small change in the odml RDF definition regarding list items of which the handling I think has changed in one of the newer RDFlib version. Once that is done I would like to keep RDF in the odml library, but make it an optional installable. Maybe these infos already help a bit in making a decision.

mpsonntag avatar Oct 14 '22 16:10 mpsonntag

My plan would be to first fix the build with the latest RDFlib version available. This will probably require a small change in the odml RDF definition

Excellent. This would also be the easiest way forward for us. Small change sounds good. Would you have an estimate when this small change can be expected? Not trying to push, just gathering info for relaying back to the group.

Thanks for the quick response.

penguinpee avatar Oct 14 '22 21:10 penguinpee

Would you have an estimate when this small change can be expected?

I would like to fix it within the next 2 month, but I am a bit swamped at the moment so please don't hold it against me if it takes a smidge longer.

mpsonntag avatar Oct 17 '22 07:10 mpsonntag

A gentle nudge: not pushing, just wondering if there is any news, any update.

penguinpee avatar Feb 13 '23 11:02 penguinpee

@penguinpee: I think I managed to upgrade to the usage of rdflib >= 6.0.0, but still need to clear some changes with the other core devs and run some tests in the ecosystem before putting up a new PyPI version.

mpsonntag avatar Apr 17 '23 08:04 mpsonntag

Thanks a lot. I'll wait for the updated PyPI package, which should trigger some notification by release monitoring on our end.

penguinpee avatar Apr 17 '23 09:04 penguinpee

A new release (1.5.3) has been uploaded to PyPI that supports rdflib v6+ by default. There should be no changes in behavior. Users that require Python <=3.6 still have to rely on rdflib v5.0.0.

mpsonntag avatar May 02 '23 13:05 mpsonntag