G.Ambatte

Results 209 comments of G.Ambatte

> @G-Ambatte Is this one ready for another review pass or are you still working on it? It's almost there, I'll try to finish this one up today/tomorrow.

> 5. It might make sense to reuse (and maybe update) the "notificationPopup.jsx" component we already have instead of making a separate component element. I've just pushed some changes now...

State of the PR: ![image](https://github.com/naturalcrit/homebrewery/assets/19826659/43284052-609e-489f-89de-1708abb3063f) Dialog components: - [x] LockNotification - [x] NotificationPopup - [x] RenderWarning To do: - [x] Shift RenderWarning to use Dialog - [x] Shift `dialog[open]` styling...

I believe that's all of the outstanding items now!

I manually added a `lock` object to a brew so that the operation can be seen on the deployment; of course I realized after the fact that this does not...

FYI the Lock Notification has both onClick and onCancel methods, so it can be cleared by pressing the ESC key. This calls the same function as clicking the "CONTINUE TO...

Final state of the PR: When a modal (blocking notification) is shown, the rest of the page dims to indicate that it cannot be interacted with. ![image](https://github.com/naturalcrit/homebrewery/assets/19826659/0082b82c-056d-4ff9-9f7d-1a15e9d40498) Regular pop ups...

On a similar note, today I stumbled across "format on save" and "lint fix on save"; it was certainly being discussed as if it is a standard option for code...

I have the ESLint extension installed for VSCode, adding this to the `settings.json` file appears to lint every file when it is saved: ![image](https://github.com/naturalcrit/homebrewery/assets/19826659/ff7972da-1e67-461b-90a2-f5b16cc924d0)