MoreCulling icon indicating copy to clipboard operation
MoreCulling copied to clipboard

Incompat with ModernFix dynamic resources and some other mods combined

Open DerCommander323 opened this issue 5 days ago • 1 comments

Hi, I'm one of the maintainers for the ModernFix-mVUS port, and someone discovered an incompatibility between More Culling and ModernFix with dynamic resources enabled that only happens with select other mods (like Easy Magic here).

Relevant log snippet:

[22:16:44] [Render thread/INFO]: Caught error loading resourcepacks, removing all selected resourcepacks
java.util.concurrent.CompletionException: java.lang.NullPointerException: Cannot invoke "ca.fxco.moreculling.api.model.BakedOpacity.moreculling$resetTranslucencyCache(net.minecraft.class_2680)" because "model" is null
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320)
	at java.base/java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:791)
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
	at knot//net.minecraft.class_4014.method_67574(class_4014.java:59)
	at knot//net.minecraft.class_1255.method_18859(class_1255.java:169)
	at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
	at knot//net.minecraft.class_1255.method_16075(class_1255.java:143)
	at knot//net.minecraft.class_1255.method_5383(class_1255.java:124)
	at knot//net.minecraft.class_310.method_1523(class_310.java:1339)
	at knot//net.minecraft.class_310.method_1514(class_310.java:966)
	at knot//net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:514)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:72)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: java.lang.NullPointerException: Cannot invoke "ca.fxco.moreculling.api.model.BakedOpacity.moreculling$resetTranslucencyCache(net.minecraft.class_2680)" because "model" is null
	at knot//net.minecraft.class_310.md5c932b$moreculling$lambda$moreculling$onBlockRenderManagerInitialized$2$3(class_310.java:10146)
	at java.base/java.util.Map.forEach(Map.java:733)
	at knot//net.minecraft.class_310.md5c932b$moreculling$lambda$moreculling$onBlockRenderManagerInitialized$3$2(class_310.java:10145)
	at knot//net.minecraft.class_4013.method_29490(class_4013.java:17)
	at java.base/java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787)
	... 15 more

Full log: https://mclo.gs/nlu4ZGs

I'm not entirely sure if this is on us to fix or if you could resolve it by just adding a null check in the line that causes the crash here.

Here's the modpack for reproducing the issue: https://files.catbox.moe/8zl77q.mrpack (mrpack export from PrismLauncher)

DerCommander323 avatar Dec 26 '25 21:12 DerCommander323