MoreCulling icon indicating copy to clipboard operation
MoreCulling copied to clipboard

Cannot optionally depend on the culling API

Open hlysine opened this issue 1 year ago • 4 comments

Hi, Create: Copycats+ dev here. We have received reports of this mod being incompatible with Copycats+, so I'm trying to implement compat by disabling culling for all our copycats (we already have advanced culling implemented in the block model, so culling done by this mod is redundant). However, because all of MoreCulling's API requires our blocks to implement an interface, I don't think it is possible to optionally depend on this mod, which makes the API unusable since we cannot force all users to download this mod.

Is it possible for other mods to opt out of MoreCulling using something more compatible (e.g. tags)?

hlysine avatar Aug 29 '24 14:08 hlysine

There are a couple ways: https://github.com/fxmorin/MoreCulling/wiki/Using-the-API Including a tag or config

FxMorin avatar Sep 21 '24 16:09 FxMorin

I need a tag that disables More Culling in general, since our copycat blocks are neither leaves nor doors.

hlysine avatar Sep 22 '24 01:09 hlysine

dont_cull is a tag which does that

FxMorin avatar Sep 23 '24 21:09 FxMorin

Reminder: List all ways for other mod devs to optionally depend on the culling API

FxMorin avatar Sep 27 '24 12:09 FxMorin

It is also possible to conditionally self mixin the interface in, although its a bit messy.

ChiefArug avatar Jan 11 '25 21:01 ChiefArug