go-client icon indicating copy to clipboard operation
go-client copied to clipboard

Please use proper module versioning tag

Open syntaqx opened this issue 7 months ago • 1 comments

Currently, if you go get this package, the value returned is:

go get github.com/FusionAuth/go-client/pkg/fusionauth@latest
go: downloading github.com/FusionAuth/go-client v0.0.0-20240703195400-20df799688c3

Which matches the latest sha in main 20df799, following pseudo-versions in go modules.

https://pkg.go.dev/github.com/FusionAuth/go-client/pkg/fusionauth?tab=versions image

This would normally not be a huge deal, except that the latest version is returning this error for my application:

# github.com/FusionAuth/go-client/pkg/fusionauth
../../../go/pkg/mod/github.com/!fusion!auth/[email protected]/pkg/fusionauth/Domain.go:4010:2: undefined: LinkedHashMap

Which we can still:

go get github.com/FusionAuth/go-client/pkg/[email protected]
go: downloading github.com/FusionAuth/go-client v0.0.0-20191211173910-6751b41cf288

However, that still pins releases as a pseudo version.

The side effect of this, is it's hard to know from what's currently a work-in-progress on the main branch vs a stable release, and even harder to pin it correctly in a go.mod

To correctly use module versions, tags should be released in the format of v1.12.1, instead of the format being used 1.12.1 (missing the v prefix).

Can you please release the latest stable as a properly named tag?

https://go.dev/ref/mod

syntaqx avatar Jul 09 '24 17:07 syntaqx