ADR for Powerplant abstraction

[je-cook]

Description

This ADR describes a possible grouping object above Reactor

Interface Changes

Checklist

I confirm that I have completed the following checks:

• [ ] Tests run locally and pass pytest tests --reactor
• [ ] Code quality checks run locally and pass flake8 and black .
• [ ] Documentation built locally and checked sphinx-build -W documentation/source documentation/build

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[github-actions[bot]]

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (10)

On collect

• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.geometry.optimisation._optimisation_old' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.opt_tools' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_problems' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.opt_problems' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_constraint_funcs' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_constraints' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.utilities.optimiser' is deprecated and will be removed in version 2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.
• /usr/share/miniconda3/envs/bluemira/lib/python3.8/site-packages/shiboken2/files.dir/shibokensupport/feature.py:139: DeprecationWarning: The module 'bluemira.equilibria.opt_objectives' is deprecated and will be removed in v2.0.0. See https://bluemira.readthedocs.io/en/latest/optimisation/optimisation.html for documentation of the new optimisation module.

On runtest

• /home/runner/work/bluemira/bluemira/bluemira/base/reactor.py:158: DeprecationWarning: Using kwarg 'dim' is no longer supported. Simply pass in the dimensions you would like to show, e.g. show_cad('xz')
• /home/runner/work/bluemira/bluemira/bluemira/builders/tf_coils.py:494: DeprecationWarning: RippleConstrainedLengthGOP API has changed, please specify how you want to constrain TF ripple by using one of the available RipplePointSelector classes. Defaulting to an EquispacedSelector with n_rip_points=3 for now.

[codecov[bot]]

Codecov Report

Merging #2512 (8137e30) into develop (1c6035a) will not change coverage. Report is 1 commits behind head on develop. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2512   +/-   ##
========================================
  Coverage    78.60%   78.60%           
========================================
  Files          217      217           
  Lines        23712    23712           
========================================
  Hits         18639    18639           
  Misses        5073     5073           

see 2 files with indirect coverage changes

[tplobo]

Just to keep in mind: this might require a further distinction for component classes, such as PlantComponent that is inherited by both ReactorComponent and (OtherSystems)Component (and possibly associated distinct component managers), since Fuel / Power Cycle components/systems (e.g. TER, Cryoplant,...) might require a completely different set of characteristics.