phoenix_pagination icon indicating copy to clipboard operation
phoenix_pagination copied to clipboard

Published 20 hours ago • verified publisher icon FunkyStudioHQ

Bump plug version

Open dorianamouroux opened this issue 1 year ago • 0 comments

Hello,

The latest version of Phoenix uses Plug with version 1.4 or above: https://github.com/phoenixframework/phoenix/blob/main/mix.exs#L73

This PR bumps the dependency of Plug to make sure this library is compatible with latest version of Phoenix.

I also tried to drop the Plug dependency, and use URI.encode_query/2 instead (https://hexdocs.pm/elixir/1.12/URI.html#encode_query/2); but it doesn't support encoding a map where some values are list. Is it an important feature to have for this library? Or could we simplify and use the standard function?

Thanks a lot!

dorianamouroux avatar Jul 30 '23 07:07 dorianamouroux