awesome-funkin-resources icon indicating copy to clipboard operation
awesome-funkin-resources copied to clipboard

Approval for main Awesome list

Open EliteMasterEric opened this issue 2 years ago • 13 comments
trafficstars

See linked issue: sindresorhus/awesome#2503

Various small issues block the actual addition of this list to the main directory of resources. Those will be listed here and checked off as they are resolved:

  • [x] Rewrite entry description (see my review of the PR).
  • [x] Enable automatic linting using awesome-lint.
  • [x] Resolve all linting issues.
  • [x] Await 30 days from first commit (February 23rd).
  • [x] Rewrite header and summary description.
  • [x] lower-kebab-case-repo-name
  • [x] Title Case Heading Title
  • [x] Set Github Topics tags
  • [x] Move deprecated entries to a separate file.
  • [x] Add logo to the header.
  • [x] Add link to logo.
  • [x] Include Awesome badge
  • [x] Revise table of contents
  • [x] Use CC0 license for list itself.
  • [x] Add Footnotes section to readme (excluded from ToC)
  • [x] Move further reading to footnotes section
  • [ ] Protect main branch
  • [ ] Disallow one-click merging of pull requests with style issues

EliteMasterEric avatar Feb 16 '23 01:02 EliteMasterEric

@lime360 as the submitter of the PR on Awesome's side.

EliteMasterEric avatar Feb 16 '23 01:02 EliteMasterEric

nice work !!!

ninjamuffin99 avatar Feb 18 '23 10:02 ninjamuffin99

thx

ghost avatar Feb 19 '23 21:02 ghost

it's been 30 days from the first commit

BombasticTom avatar Feb 26 '23 11:02 BombasticTom

@BombasticTom Yep! With that, looks like all linting checks currently pass on the main branch.

EliteMasterEric avatar Feb 27 '23 03:02 EliteMasterEric

@EliteMasterEric I made main a protected branch, what entails for Disallow one-click merging of pull requests with style issues?

ninjamuffin99 avatar Mar 11 '23 20:03 ninjamuffin99

@EliteMasterEric I made main a protected branch, what entails for Disallow one-click merging of pull requests with style issues?

There is a GitHub Action on this repo that adds a build action, which performs style checking using a library built by the creators of the Awesome list.

There should be an option that disallows merging pull requests with build failures on them. So if the person's PR has style issues that need to be fixed we can't merge it by mistake.

EDIT the option is called Require status checks to pass before merging

So if the status of the PR is failure you can't merge it

EliteMasterEric avatar Mar 11 '23 20:03 EliteMasterEric

pinning this till we get it done

EliteMasterEric avatar Mar 30 '23 04:03 EliteMasterEric

for people who don't know: I am the one who suggested this to be on main awesome list

ghost avatar May 04 '23 14:05 ghost

nice

BombasticTom avatar May 04 '23 15:05 BombasticTom

@lime360 please address this comment:

https://github.com/sindresorhus/awesome/pull/2503/files#r1123587843

EliteMasterEric avatar May 04 '23 16:05 EliteMasterEric

It appears that Lime360 has deleted their account.

TODO: Submit a new request for approval on the Awesome list.

EliteMasterEric avatar Jul 02 '23 02:07 EliteMasterEric

are the last 2 things resolved?

BombasticTom avatar Jul 02 '23 13:07 BombasticTom