FunkinCrew
[BUGFIX/Chart Editor] Center waveforms on health icons and adjust icon X-offsets
Linked Issues
Fixes #5468
Description
The voice waveforms were misaligned with the health icons because they used preset positions, causing them to appear off-center. This PR fixes that by centering them on the health icons, correcting the alignment for any resolution.
It also aligns the icons x position to now be based on the width of the icon instead of preset, which might bring visual issues for larger icons.
Screenshots/Videos
Before (0.7.5):
Wide Screen (0.7.5):
This PR (After):
Wide Screen (After)
Just noticed the waveforms render incorrectly if you press the Chart Editor key in either Freeplay or PlayState. Not sure what's different about those, but please fix this
I wonder if this happens in dev 🤔 I'll check, but I didnt think that since I never used the keys myself 😅
Alright, you fixed it! One more thing I'd like is for Boyfriend's icon to be nudged slightly to the left. Before this PR, the waveforms were equally distanced from the chart grid, but now the player's is a little further away. Can you move him (or his waveform) just a bit to the left?
Eric didn't like the way the player's icon would display far away from the grid (to the right) for specific resolutions If you can fix that, this can definitely make it in
Actually, I don't think this will get approved until it works cleanly with those specific bugged resolutions. Please look into this!
I'd need more information for this, like which "specific bugged resolutions"? I will try these days to fix it and hopefully it's approved before next update 👍