Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Completely un-hardcode songs, various fixes and improvements

Open Enovale opened this issue 5 years ago • 7 comments

Apologies for not splitting this shit into a bunch of smaller pull requests, it ended up being much more ambitious than I originally planned.

So basically I redid the way songs are loaded so that a song's music, json, and metadata are all stored in a self contained folder, and all songs are dynamically loaded from "songs/". What this means is you can now create your own song, put it into the files, and play it in Freeplay without rebuilding the game.

Along with this I also made it so the story mode is loaded dynamically from a JSON, so the end user could even make their own campaign using their own custom songs, and it makes creating more story mode weeks easier on the developer side.

I also made sure that official songs are included in the assets on web platforms because HTML5/Flash do not have filesystem support.

The problem is that merging this is gonna take more work than just pressing the github merge button. I changed a lot of shit here and not everything is perfect. The most notable is that the story mode screen doesnt show the week names properly, and it looks like shit. That's because you originally used hard coded sprites for the week names, and your Alphabet class/art doesn't have bold numbers in it.

I wanna see this game become the Clone Hero of Newgrounds, and to do that i'll need some help from you guys to merge this pull request. Thank you.

Lemme know if you need my help, have questions, whatever :P

Enovale avatar Dec 10 '20 16:12 Enovale

got a good chunk of changes, finished up week 3 update, so gonna dig thru this rn

ninjamuffin99 avatar Dec 13 '20 06:12 ninjamuffin99

I can make changes or whatever if somethin doesnt fit your style or you can't figure out something. I didn't comment much of my code, sorry

Enovale avatar Dec 13 '20 18:12 Enovale

So where is songs/

josiauh avatar Dec 22 '20 04:12 josiauh

Theres a "bug" (I intended it at the time but kinda regret it) where it wont copy the songs folder to the output build because i dont want to have to compile all the songs if you're on desktop. Just copy the songs/ folder from the source tree to your output build next to the main binary

Enovale avatar Dec 22 '20 05:12 Enovale

Any updates on this?

Enovale avatar Dec 28 '20 10:12 Enovale

still gotta peep thru this! and will! just got week 4 update, so gonna spend the next little while to update programming backend stuff

ninjamuffin99 avatar Dec 28 '20 21:12 ninjamuffin99

Was this still considered to be merged @ninjamuffin99 or has it been implemented in another way at this point?

Coolguy3289 avatar Apr 06 '21 22:04 Coolguy3289