Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Published 20 hours ago • verified publisher icon FunkinCrew

[ENHANCEMENT] Freeplay Favorites by Variation

Open KoloInDaCrib opened this issue 6 months ago • 4 comments

Linked Issues

Closes https://github.com/FunkinCrew/Funkin/issues/3276

Description

Turns isFav into a getter variable.

Screenshots/Videos

https://github.com/user-attachments/assets/1b9ee8a5-3f31-4515-bd10-f4c20fb0392c

KoloInDaCrib avatar May 24 '25 10:05 KoloInDaCrib

pleasepleasepleaseplease

TheJadeMirror avatar May 25 '25 02:05 TheJadeMirror

i need this!!

MrBossGuy36 avatar May 25 '25 19:05 MrBossGuy36

I like isFav as a property but using the song NAME seems wonky since it messes up favorites if we ever tweak the name of something. Should probably use <songid>-<variation>, like dadbattle-erect.

EliteMasterEric avatar Jun 11 '25 08:06 EliteMasterEric

I like isFav as a property but using the song NAME seems wonky since it messes up favorites if we ever tweak the name of something. Should probably use <songid>-<variation>, like dadbattle-erect.

Initially I had that system (in fact you can ignore the 2nd commit and use the first one cuz it has that), the only reason I opted for the songName is cuz of backwards compatibility, which also used the songName

KoloInDaCrib avatar Jun 11 '25 09:06 KoloInDaCrib

Wondering what @EliteMasterEric wants to see changed before this can be merged. It's a good feature

Hundrec avatar Aug 13 '25 08:08 Hundrec