Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

[FEATURE/ENHANCEMENT] Set Character Event

Open anysad opened this issue 8 months ago • 8 comments

Requires https://github.com/FunkinCrew/funkin.assets/pull/164 for this to work properly!

Briefly describe the issue(s) fixed.

  • This PR aims to add a new song event where you are able to change the desired character mid-song!
  • A new function loadCharacter(charId:String, charType:CharacterType, ?swap:Bool = false) is made to have the ability to easily add the characters and swap them within your mods.
  • Also made some cleaning of the code in initCharacters()

‼️ THIS WILL BREAK MODS THAT USE CharacterType‼️

Include any relevant screenshots or videos.

https://github.com/user-attachments/assets/a153c273-294e-4bd0-801d-65738b04598f

anysad avatar Apr 15 '25 19:04 anysad

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

images (2) (22) images (2) (23)

trayfellow avatar Apr 16 '25 09:04 trayfellow

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

lolol hopefully this gets accepted so you can finally be happy

anysad avatar Apr 16 '25 10:04 anysad

Now closes https://github.com/FunkinCrew/Funkin/issues/5269 :D

NotHyper-474 avatar Jun 25 '25 21:06 NotHyper-474

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

togif

(from https://github.com/FunkinCrew/Funkin/pull/5000#issuecomment-2852487823)

Not sure why it broke but whatever

Lasercar avatar Jun 29 '25 10:06 Lasercar

FINALLYYYYYY I'VE WAITED AGES FOR NATIVE SUPPORT ON THIS

togif togif

(from #5000 (comment))

image

charlesisfeline avatar Jun 29 '25 18:06 charlesisfeline

WHEN IT ADDED IT?!?

Mlaofmd avatar Sep 06 '25 21:09 Mlaofmd

This and its associated PR (#4663) are interesting. I'll have to review these and see how much rewriting needs to be done as more work gets done on asset preloading reworks.

EDIT: I had a barebones, kinda-working version at one point but I don't know where that went, and your implementation seems more mature anyway.

EliteMasterEric avatar Dec 03 '25 14:12 EliteMasterEric

Just to add onto this what if you were able to change the x and y coordinates too? It could be useful in modding I think since some characters don't always fit with particular stages and they always have to be adjusted

LumixX-git avatar Dec 03 '25 15:12 LumixX-git