[BUGFIX] Fix Freeplay Rank Animation when switching songs
Does this PR close any issues? If so, link them below.
Fixes #4530
Briefly describe the issue(s) fixed.
~~The rank animation in freeplay plays whenever you switch songs. This PR fixes this by adding a default argument to refreshDisplay in SongMenuItem.hx to check whether the rank should be updated.~~ This has been done already in a merged PR. (See the comment from Lasercar below)
I made the call to refreshDisplay in changeSelection always pass in a value of false over the default true.
I also made a similar change to the changeDiff function to allow me to always pass in a value of false in its call to refreshDisplay when changeDiff is being called in changeSelection.
Include any relevant screenshots or videos.
Before changes:
https://github.com/user-attachments/assets/1035ca21-bdf9-4639-8d0e-f6688069b874
After changes:
https://github.com/user-attachments/assets/c73b8d82-363e-497a-8ea3-3bc58819f5e9
Thank you this is better
I love that this code is compatible with https://github.com/FunkinCrew/Funkin/pull/4214
I love that this code is compatible with #4214
That's funny. I didn't look at that PR, but I ended up making the exact same change to the refreshDisplay function.
but i love how ranking poping when i select songs
Something got messy internally with this conflicting with another change, so we'll have to wait to accept this one.
Freeplay got refactored at some point, which made the merge conflicts very difficult to resolve.
If you'd like to bring back this change, please open a new PR based on this commit: 83d876bac11a55ca32debcc055d2110caf69fb0c
my feelings when 0 commits