Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard
verified publisher icon FunkinCrew

[BUGFIX] Characters do not play confirm animation if selected mid transition

Open Lasercar opened this issue 9 months ago • 4 comments

Does this PR close any issues? If so, link them below.

Fixes #3730

Briefly describe the issue(s) fixed.

Characters do not play confirm animation if selected mid transition. The pressed Selected bool is now passed when they're switched and plays the confirm animations instead if it's true.

Include any relevant screenshots or videos.

Lasercar avatar Mar 07 '25 02:03 Lasercar

Lasercar carrying ezgif-76b21c61936a5c

trayfellow avatar Mar 07 '25 19:03 trayfellow

Could this also fix the memory leak from spam selecting between characters? i got to around 10gb ram usage only from doing that (yes I am sane)

Starexify avatar Mar 07 '25 21:03 Starexify

Could this also fix the memory leak from spam selecting between characters? i got to around 10gb ram usage only from doing that (yes I am sane)

~~Sure, I'll see if I can do a simple cache hack.~~

~~Hmm, but they're altas sprites so I'm not even sure if they can be cached atm.~~ Altas sprites cannot be cached currently.

Lasercar avatar Mar 07 '25 23:03 Lasercar

Not familiar with the bugs this PR fixes, but it needs a conflict resolution

Hundrec avatar Aug 20 '25 12:08 Hundrec