FunkinCrew
[ENHANCEMENT] Chart Editor - welcome back, welcome music
Does this PR close any issues? If so, link them below.
Fixes #4146, closes #6026
Briefly describe the issue(s) fixed.
The welcome music could only ever play once after being set to true.
This fixes that, and adds options to modify the fade in delay and duration.
Welcome back, welcome music.
Requires this assets PR: https://github.com/FunkinCrew/funkin.assets/pull/123
Include any relevant screenshots or videos.
https://github.com/user-attachments/assets/888d7701-c59c-4eb2-a71b-7f6ea4051dac
Thx
Uh, sure, no problem? (I'm guessing you've checked out this PR of mine?)
i thought the fade in delay being an option was kinda dumb until i saw it in action, it's genuinely cool! nice jooob (it would be nice if the number steppers could be smaller in width, so t hey don't take 2 whole lines, it makes the context menu look kinda cluttered)
i thought the fade in delay being an option was kinda dumb until i saw it in action, it's genuinely cool! nice jooob
Well I only added it because the default delay was thirty seconds, which is way too long imo. So, why not allow people to set their own delay, and while we're at it, the duration of the fade in too?
(it would be nice if the number steppers could be smaller in width, so t hey don't take 2 whole lines, it makes the context menu look kinda cluttered)
Sure, I was trying to do something like this before but gave up, but I'll give it another go, though I'm currently investigating the playspeed stutter issue.
Works perfectly! I love the added ability to customize the fade-in. This is just a personal suggestion, but I recommend adding an option to customize the volume of the welcome music. Since that is not something that is 100% needed though, I will approve this PR since it does exactly what is advertised.
If you know of a spot in the stage editor UI that I'd be able to put a volume slider for the welcome music somewhere, then I'm all ears.
Quick review of this, code seems fine but I agree that having an option for it makes no sense and kinda leads to option bloat. It would be better to just determine new correct value for the fade in time that makes it appear more reliably without annoying users. And, of course, leave in your fixes to looping and such.
Hmm, might see if I can ask people to test what values are best for the delay and fade in...
Alright, I've removed the the customizable delay and fade in duration. They're now set to 10 and 20 seconds respectively.
I've also fixed a few more issues I noticed.