Funkin
Funkin copied to clipboard
FunkinCrew
check if response result is actually there
follow up on #362 fixes #410 the thing that was causing problems with an invalid API key was response.result being null since the response Newgrounds gives just tells us that we have an invalid app id.
Since we now actually create NG.core we will always get a console message when anything with NG.core is done that requires the api.
wait is this like a failsafe
Yeah? It just ensures that nothing should happen if the response returns a null result. The original failsafe check was just checking if api's Length was 0, which clearly didn't work.
The original implementation was rather simplistic with and never actually created a Newgrounds object when the api key was empty this works in theory but every time you change song in Freeplay it makes Newgrounds calls, which fall on deaf ears because were never init'd it
this patch changes it around to see if we actually get a response Invalid API keys (such as an empty one) will cause the library to output a warning and null any response that was expected to have something accessing a member of null isn't possible so we crash
Sooo can we merge? Right now freeplay is not playable (I get a "NULL object reference" error)
Despite the branch being super old there are still no merge conflicts and it's impossible to play freeplay without it. Merging this is a no-brainer.
Pinging @ninjamuffin99 because this PR seems like it's been overlooked.
Very well could have already been fixed on a private branch. You guys are forgetting that the public GitHub repository isn't up-to-date.
Very well could have already been fixed on a private branch. You guys are forgetting that the public GitHub repository isn't up-to-date.
Isn't this the only way we can actually see changes being made before release though?
Feel free to do whatever with this on that note
Yes it is likely that development is continuing in a private repo considering the Kickstarted
