FunkinCrew
[ENHANCEMENT] Freeplay results screen
Does this PR close any issues? If so, link them below.
Closes #2441
Briefly describe the issue(s) fixed.
Opens a results screen for the current song and difficulty when you press R (default keybind) and it has a score.
I would have it open in a substate and then close it to return to the Freeplay menu so it doesn't have to reload the freeplay state but doing that seems to cause the freeplay state to become a weird pink screen (until you back out)? If someone can figure out why I could instead make it a substate.
Include any relevant screenshots or videos.
https://github.com/user-attachments/assets/0547e66c-aca4-4b5c-a247-1c34baaac9a0
There should be an option at the top of the screen to change the base branch from main to develop!
Just checked it, and it works pretty good! I will approve this PR. I do have a couple recommendations though
- Disable it for songs that you don't have any score on. It doesn't really make much sense, and it also gives you an L rank on the song, even though it does disappear after re-hovering over the song.
- Add the ability to change the keybind in the options menu.
Just checked it, and it works pretty good! I will approve this PR. I do have a couple recommendations though
1. Disable it for songs that you don't have any score on. It doesn't really make much sense, and it also gives you an L rank on the song, even though it does disappear after re-hovering over the song. 2. Add the ability to change the keybind in the options menu.
Ah, I thought I did that. I guess favouriting a song creates an empty score and allows you to go into the results screen.
I'll definitely add a keybind for it too.
Done!
Just checked it, and it works pretty good! I will approve this PR. I do have a couple recommendations though
1. Disable it for songs that you don't have any score on. It doesn't really make much sense, and it also gives you an L rank on the song, even though it does disappear after re-hovering over the song. 2. Add the ability to change the keybind in the options menu.Ah, I thought I did that. I guess favouriting a song creates an empty score and allows you to go into the results screen.
I'll definitely add a keybind for it too.
Done!
Cool, I’ll check it out rn
Alright the changes work great! I consider this PR to be 100% perfect now. Hopefully it gets merged soon.
This is AWESOME! Now I can show off my L on Tutorial any time! Results.Screen.PR.Test.mp4
Heh, LoL.
Hey, you might want to consider putting this https://github.com/FunkinCrew/Funkin/pull/4149#issuecomment-2661146657 in the contributor's guide, in a lil mini section for reviewing stuff.
It doesn't seem to be common knowledge so it should be alright to add.
Sure, I'll see what Eric thinks and I'll be happy to add a Playtesting section to the guide!
Nice:
https://github.com/user-attachments/assets/de8baaec-55e3-4ace-9476-ebe4126857db
Too bad I'm not logged in to Newgrounds:
Only real improvement to add is to prevent awards from being awarded and stuff, but idk.
