Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

[BUGFIX/ENHANCEMENT] Miscellaneous Stage Editor Bugfixes and Missing Features

Open KoloInDaCrib opened this issue 11 months ago • 14 comments

Does this PR close any issues? If so, link them below.

Fixes #3973 Fixes #4487 Fixes #3666 Fixes #4458 Fixes #4771 Fixes #4785

This PR includes

  • The aforementioned bug fixes
  • More Removed Remnants of Stage Editor Engine (i.e. funkin fork engine where the editor originated from)
  • Added Asset de-selecting
  • Fix for the asset selection shader being present during testing mode
  • Fix for the images being cleared after selecting a file
  • Changes to the selection priority (based on z-Index rather than when the object was added)
  • Missing features for both objects (such as flipping) and characters (like alpha or angle)
  • Fix for the blend mode not being applied on single-colored objects
  • Removal of the pixel perfect sprites (RIP)
  • Fixed pasting not adding the sprite
  • Optimized saving stages
  • Added the ability to load .fnfs files outside the application, like the .fnfc files
  • Made it so that new objects have the highest zIndex of all objects
  • Characters to test as are now saved

KoloInDaCrib avatar Jan 04 '25 21:01 KoloInDaCrib

Looks like the crash fix has been fixed in 0.6.0, finally.

Lasercar avatar Apr 01 '25 14:04 Lasercar

Watch out for merge conflicts hiding in the stage editor

Hundrec avatar Apr 05 '25 03:04 Hundrec

  1. This PR has merge conflicts with the develop branch.
  2. I tried to do some basic testing and had issues. I tried loading the Main Stage, creating a new stage prop, and adding an image to it, but the image never showed in the stage. Additionally, when I then tried to replace the image of an existing stage prop, the game froze.

I have no objections from the code review though, and I really like the addition of FNFS files, that should really make future development a lot easier.

EliteMasterEric avatar Apr 21 '25 23:04 EliteMasterEric

I tried to do some basic testing and had issues. I tried loading the Main Stage, creating a new stage prop, and adding an image to it, but the image never showed in the stage. Additionally, when I then tried to replace the image of an existing stage prop, the game froze.

Honestly cannot reproduce either one of these bugs. For the first one I assume it was because the zIndex of the object had been set to a small value. As for the 2nd I had tested this with both larger and smaller images and if anything it took no longer than a couple of seconds. The branch had been updated to not include merge conflicts though.

https://github.com/user-attachments/assets/e9705a4b-79a8-466c-b5a6-51241c1d34c4

Are there other issues I should be concerned about?

KoloInDaCrib avatar Apr 22 '25 04:04 KoloInDaCrib

I think this PR needs a rename, as it adds new features and stuff in addition to the bugfixes.

Also might want to format the description and have the features and bugfixes under separate headings or something.

Lasercar avatar Apr 22 '25 07:04 Lasercar

I think this PR needs a rename, as it adds new features and stuff in addition to the bugfixes.

The "missing features" part on the table:

KoloInDaCrib avatar Apr 22 '25 07:04 KoloInDaCrib

I think this PR needs a rename, as it adds new features and stuff in addition to the bugfixes.

The "missing features" part on the table:

Well, I was moreso taking issue with the [BUGFIX] It should be [BUGFIX] + [ENHANCEMENT] ?

Lasercar avatar Apr 22 '25 08:04 Lasercar

I tried to do some basic testing and had issues. I tried loading the Main Stage, creating a new stage prop, and adding an image to it, but the image never showed in the stage. Additionally, when I then tried to replace the image of an existing stage prop, the game froze.

Hmm, maybe the editor couldn't find the image and it ended up being null or something?

Oh hmm, what image format was it?

Lasercar avatar Apr 22 '25 08:04 Lasercar

This PR has merge conflicts, please fix them!

AbnormalPoof avatar Apr 29 '25 20:04 AbnormalPoof

Would this fix #4975?

There's also merge conflicts again btw

VioletSnowLeopard avatar May 04 '25 02:05 VioletSnowLeopard

Would this fix #4975?

yeah

There's also merge conflicts again btw

in a moment

KoloInDaCrib avatar May 04 '25 06:05 KoloInDaCrib

There's also merge conflicts again btw

in a moment

Really long moment imo

Lasercar avatar May 12 '25 08:05 Lasercar

status: reviewing internally

Please 0.7.0 img

NotHyper-474 avatar Jun 11 '25 19:06 NotHyper-474

ItsHappeningGIF

Lasercar avatar Jun 12 '25 07:06 Lasercar