Funkin
Funkin copied to clipboard
Crash Report: Game Crash when spamming enter in spotlight cutscene
Issue Checklist
- [X] I have properly named the issue
- [X] I have checked the issues/discussions pages to see if the issue has been previously reported
What platform are you using?
Itch.io (Downloadable Build) - Windows
If you are playing on a browser, which one are you using?
None
Version
0.5.0
Context (Provide screenshots or videos of the crash happening)
https://github.com/user-attachments/assets/9b47f1ad-89b0-451e-8f1f-7f35e6a18b62
Steps to reproduce
When getting the Spotlight cutscene repeatedly press enter, this will then crash the game, im guessing the actual cause is pressing enter right after the cutscene ends.
Crash logs (can be found in the logs folder where Funkin.exe is)
纯后台修改,通过代码验证
3.2411.0影响面
修复后生成的指纹会有些区别 eg:
- 指纹关键字是大写字符
- 指纹中表名、字段名带反引号
- sqle/pkg/driver/impl.go 中 DriverImpl.Parse 方法中 这里业务没有直接使用,插件中也会自己实现Parse方法,暂无影响
- sqle/cmd/scannerd/scanners/tidb_audit_log/audit_log_ee.go 这里会导致使用scannerd采集tidb_audit_log上报相同sql的指纹不一致,导致智能扫描中统计数据无法与旧记录一起计算
3.2404.1 影响面
修复方案
只处理panic问题,不影响指纹算法
这样处理的原因:
- 3.2407.0开始,智能扫描已经重构,且不再使用query.Fingerprint(sql)这个函数,不会再有panic问题
- 本次处理在小版本3.2404.1发布,如果使用和3.2407.0之后相同的修复方案,旧的指纹和新的指纹会有不一样。对于旧数据的影响面很大,升级成本较高
影响面
触发panic的SQL会使用"github.com/actiontech/sqle/sqle/driver/mysql/util"库里的Fingerprint()函数计算指纹
受影响的功能:
- huaweiRdsMySQLTask
- aliRdsMySQLTask
- baiduRdsMySQLTask
- MySQLProcesslistTask