Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Bug Report: Visual/Audio Offset causes weirdness with chart and song start time

Open Squiddu opened this issue 1 year ago • 9 comments

Issue Checklist

  • [X] I have properly named the issue
  • [X] I have checked the issues/discussions pages to see if the issue has been previously reported

What platform are you using?

Itch.io (Downloadable Build) - Windows

If you are playing on a browser, which one are you using?

None

Version

0.4.1

Context (Provide images, videos, etc.)

After making adjustments to the Visual Offset in the settings, song charts will scroll up as if they were never set and then "jump" to the correct visual offset when the song's chart starts. Song itself will "jump" to match the note, starting it prematurely.

https://github.com/user-attachments/assets/5d90ff20-d2b7-4076-bc62-3ca02ca42a0c

Steps to reproduce (or crash logs, errors, etc.)

Go into Options > Visual Offsets Set Visual Offset to something like +100ms Play Eggnog Erect since it's one of the only charts in-game that has a player note at the very start Note should unreasonably jump to streamline

Squiddu avatar Jul 18 '24 04:07 Squiddu

Bumping this with two new things to add:

  1. I can confirm that only the Visual Offset seems to cause the audio and chart jump. Input still is slightly funky but it's Visual that's the problem.

  2. Changing the Input Offset causes the notes with short holds to, when hit, ~~completely~~ remove the hold. Hitting only the hold part does not get rid of it. Since this has also come up I think I can rename the issue.

Edit: 2 actually depends on the scroll speed. When testing using Tutorial as a lab rat, I can visibly see the note hold get shorter when I hit it, but it disappears on Eggnog Erect due to the high scroll speed.

Squiddu avatar Jul 22 '24 02:07 Squiddu

For extra clarification, using a test Visual Offset of 100ms like I did should make the song start prematurely, before the beat after the Go! soundbite completes. Also, this works on every song, but Eggnog Erect is just the most notable. I can only assume it only applies offset when the chart starts, but it also confuses me as to why changing the VISUAL Offset also messes with the audio like this.

Nor do I understand the note trail weirdness with the Input Offset setting. Either way this is incredibly disorienting and should be fixed relatively quick if we want people to actually use these settings.

Squiddu avatar Jul 25 '24 02:07 Squiddu

Bumping this up, as all these issues still exist in 0.5.0, including a new bug where occasionally, starting off a song with visual and input offset will make the song and chart "jump" every beat.. I haven't been able to gather much, but it does seem to at least partially be songs starting earlier than they should.

Squiddu avatar Sep 13 '24 16:09 Squiddu

whatever that stuttering issue that some people are having is.. yep that's happened to me too. oh my god fix the gosh darn offsets!!!

Squiddu avatar Oct 01 '24 04:10 Squiddu

This is still happening and it's really unfortunate because all the bugfixes are basically unplayable for me because my audio is delayed by 40ms and having the notes offset before that really throw me off

floofycatto avatar Dec 21 '24 01:12 floofycatto

Luckily I have a setup that doesn't really require much offset at all normally, but yeah, it seems like normally they respond really quick to most issues.. of course this is the one they don't seem to notice lol

though at the same time I don't know if I ever tested this enough, it feels like there might be a lot of weird nuances with it that I didn't write down

Squiddu avatar Dec 23 '24 18:12 Squiddu

It's been about another month, so I'm bumping this again. I wouldn't be so concerned if not for not really seeing any other bug report cover this, and this not even getting any labels when issues with less interactions do.

WHY???

Squiddu avatar Jan 21 '25 18:01 Squiddu

This has a pending PR?

Lasercar avatar Feb 12 '25 14:02 Lasercar

The PR fixes part of the issue, but not all of it. Related but won't fix it.

Squiddu avatar Feb 20 '25 06:02 Squiddu