Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

FIXES CHARACTER PATH ONLY CHECKING IN SHARED

Open 7oltan opened this issue 1 year ago • 8 comments

so im trying to make it so it will load characters from a week dir but its not letting me so i checked and saw this was the problem so i fixed it :3

7oltan avatar Jul 16 '24 09:07 7oltan

I don't think this is a good idea since I don't think it checks in shared by default

moxie-coder avatar Jul 16 '24 10:07 moxie-coder

why not just place character assets in shared/images/characters?

anysad avatar Jul 16 '24 14:07 anysad

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

anysad avatar Jul 16 '24 14:07 anysad

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

moxie-coder avatar Jul 16 '24 14:07 moxie-coder

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

why tho?

7oltan avatar Jul 16 '24 17:07 7oltan

why not just place character assets in shared/images/characters?

i want to add the characters in a week type dir to save memory and just to make images look cleaner

7oltan avatar Jul 16 '24 17:07 7oltan

I don't think this is a good idea since I don't think it checks in shared by default

it doesn't check in shared by default, it initially checks in preload

I know, that's kinda why I think this might cause issues

how would it be an issue? it checks first for preload, then for the level path, and then shared

mayo78 avatar Jul 18 '24 17:07 mayo78

Paths automatically checks which library has the file before using it, so this should be good.

I believe characters were originally IN the level folders before moving them out due to issues when characters were shared between levels.

EliteMasterEric avatar Jul 23 '24 04:07 EliteMasterEric

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

7oltan avatar Dec 16 '24 09:12 7oltan

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

I don't understand what you mean, if this breaks things then Blazin' would be unplayable.

EliteMasterEric avatar Dec 16 '24 15:12 EliteMasterEric

@EliteMasterEric so this may or may not have broken how animate atlas characters work, since paths for animate atlases uses getLib path and now that's it's null it ONLY checks in preload, and before that it only checked in shared, you should make it so the paths.animateAtlas takes the path and checks for its animate json file by normal getPath and then make it go back a few to the folder

I don't understand what you mean, if this breaks things then Blazin' would be unplayable.

The characters in blazin' put "shared:" in the start of the path; but mods that don't before it would work for them and now their characters are broken image

7oltan avatar Dec 19 '24 11:12 7oltan

kinda not a problem though? in normal flixel projects you already get assets from libraries in that way

mayo78 avatar Dec 23 '24 01:12 mayo78