Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

[ENHANCEMENT] Open PauseSubState on PlayState Focus Loss

Open CrusherNotDrip opened this issue 1 year ago • 5 comments

This PR makes it so it opens the PauseSubState when the game loses focus on PlayState.

This is helpful in a scenario where before this pr, they might just mess up as they dive immediately right back into the game if they didn't pause already. After this pr, if the player unfocused the game, it will pause the game helping them prepare to hit their keys again and they don't funk up their current progress in the song.

CrusherNotDrip avatar Jul 11 '24 02:07 CrusherNotDrip

Isn't this supposed to be OFF if Auto-Pause is disabled? I'd imagine that if Auto-Pause is off, the user probably, you know, wouldn't want the game to automatically pause.

Also I'm confused as to why your code wouldn't work in charting mode, you can still pause the game in the playtest.

EliteMasterEric avatar Jul 11 '24 07:07 EliteMasterEric

Isn't this supposed to be OFF if Auto-Pause is disabled? I'd imagine that if Auto-Pause is off, the user probably, you know, wouldn't want the game to automatically pause.

You know what fair enough but even with it being turned on, the game only freezes on focus loss so should I just make this go only with the auto pause preference ON then? or would this PR just be a no go?

Also I'm confused as to why your code wouldn't work in charting mode, you can still pause the game in the playtest.

im confused too 😭😭😭

CrusherNotDrip avatar Jul 11 '24 10:07 CrusherNotDrip

I feel like if this was changed to work only for auto pause, then this would work perfectly

Cartridge-Man avatar Jul 29 '24 01:07 Cartridge-Man

I feel like if this was changed to work only for auto pause, then this would work perfectly

i forgot about this pr so ima just do it rn

CrusherNotDrip avatar Jul 29 '24 03:07 CrusherNotDrip

lol nice

Cartridge-Man avatar Jul 30 '24 18:07 Cartridge-Man

This PR appears to have merge conflicts. Please fix them!

AbnormalPoof avatar Jan 22 '25 18:01 AbnormalPoof

oop

CrusherNotDrip avatar Jan 23 '25 03:01 CrusherNotDrip

chat i might've messed up

CrusherNotDrip avatar Jan 23 '25 03:01 CrusherNotDrip

ok there we go

CrusherNotDrip avatar Jan 23 '25 03:01 CrusherNotDrip

doesn’t account for having a cutscene playing, so cutscene options don’t show up

oh thank you sherlock holmes i didn't know such information

CrusherNotDrip avatar Mar 20 '25 18:03 CrusherNotDrip

doesn’t account for having a cutscene playing, so cutscene options don’t show up

oh thank you herlock sholmes i didn't know such information

The art of deduction

Lasercar avatar Mar 21 '25 07:03 Lasercar

The art of deduction

trues...

TechnikTil avatar Mar 21 '25 14:03 TechnikTil

Please fix up the merge conflicts!

Hundrec avatar Apr 05 '25 03:04 Hundrec

crusher get off schedule I and fix ur pr

TechnikTil avatar Apr 05 '25 04:04 TechnikTil

man i really hope that works

CrusherNotDrip avatar Apr 05 '25 05:04 CrusherNotDrip

that surprisingly worked😭

TechnikTil avatar Apr 05 '25 05:04 TechnikTil

All in a day's work

Hundrec avatar Apr 05 '25 06:04 Hundrec

speaking of a days work i got 1k in a day in schedule I

CrusherNotDrip avatar Apr 05 '25 06:04 CrusherNotDrip

speaking of a days work i got 1k in a day in schedule I

ok man

TechnikTil avatar Apr 05 '25 19:04 TechnikTil

speaking of a days work i got 1k in a day in schedule I

Stop slacking off and do some actual day work

Lasercar avatar Apr 06 '25 04:04 Lasercar

Welp

CrusherNotDrip avatar Jul 25 '25 23:07 CrusherNotDrip