FunkinCrew
Bug Report: Pico's Explosion Game Over Song Doesn't Loop
Describe the bug
When playing the song 2Hot in Weekend 1, there is a secret death song for being exploded. However, when the song loops, it abruptly ends, and then slowly fades in again.
To Reproduce
literally die to an explosion and wait till the loop
Expected behavior
For the song to not abruptly end OR After that song ends, to play the regular song (the song without the fade in)
Screenshots/Video
youtube.com/watch=you-should-see-my-other-issue
Desktop
-
OS: Windows 11
-
Browser: Opera GX (should work on any build though)
-
Version: 0.3.2 to 0.4.1 (including all inbetween)
Additional context
none
Whoops! Meant to put Edge as the browser! Shouldn't matter anyways, it works on any build.
Just took a look, and the issue is a bit more complicated than I first thought.
^^^
This function in 2hot's scripts handles Pico's explosion death music and animation.
^^^
This function seems like it should handle looping
fnf_loss_sfx-suffix rather than gameOverStart-suffix
I've replicated and recorded the bug here:
https://github.com/FunkinCrew/Funkin/assets/170126004/7519dce5-667c-42da-8692-a506035424ce
the comment "this code is jank as hell" lol
i dont know any C, but i know my ways kinda
onComplete (function after completion) play picodeath (regular death)
one thing to note is that during the fade in if you press retry the retry sound isn't faded in either but that doesn't matter that much
also they need to give you a raise/pay you if you aren't already because you have been fixing issues left and right
and if you have time, i have two other issues
edit: 4 more issues
It's alright, I do this for fun! I don't know how to code, but I'm happy to help however I can.
It's alright, I do this for fun! I don't know how to code, but I'm happy to help however I can.
No dude you are literally the Github guy at this point you literal handle so much of their stuff and do it so professionally they should pay you bro you deserve it at this point. You like an under the counter hire my guy 😭
This still happens in 0.5.2, which has a hilariously broken explosion game over bug (https://github.com/FunkinCrew/Funkin/issues/3182)
https://github.com/user-attachments/assets/46cd7274-d439-4713-8b55-ac0928e4c25d
you could easily replace "/assets/weekend1/music/gameplay/gameover/gameOverStart-pico-explode.ogg" with "/assets/shared/music/gameplay/gameover/gameOver-pico.ogg", however that would remove the feature of the music fading in.
we could also modify the code to play "gameOverStart-pico-explode.ogg" ONCE, and then keep looping "gameOver-pico.ogg". this approach keeps the fade-in, and still loops perfectly fine.
That's what I sought to do when I was digging around in the code, but I couldn't figure out what was responsible for what (I don't code)
Hopefully the code I linked is helpful for someone else to make a PR!
you could edit the code to change the music suffix back to normal after the explosion music starts playing
