Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

[BUGFIX] Charting Editor Sustain Trails (2 bugs)

Open gamerbross opened this issue 1 year ago • 2 comments

This pull request fixes two bugs:

Note Sustain Trails getting cut/inverted when is downscroll enabled

Before After
image image

Incorrect Sustain Trails origin note (based on ghost note)

Before After

Hope this gets added soon =D

gamerbross avatar May 20 '24 00:05 gamerbross

i got one of these problems before, tysm

charlesisfeline avatar May 20 '24 00:05 charlesisfeline

the Incorrect Sustain Trails origin note has actually been bothering me for a while, this is cool :)

amyspark-ng avatar May 20 '24 05:05 amyspark-ng

Approving because this does fix stuff, but currently Downscroll on chart editor doesn't fully work as intended (It's supposed to flip the note grid vertically and scroll upwards, I never properly implemented that which is why it's grayed out in the editor).

EliteMasterEric avatar May 29 '24 04:05 EliteMasterEric

Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?

gamerbross avatar May 29 '24 12:05 gamerbross

Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?

Ah that explains it! We can leave flipY = true in place for now until I get around to making downscroll work.

EliteMasterEric avatar May 30 '24 02:05 EliteMasterEric