Funkin
Funkin copied to clipboard
[BUGFIX] Charting Editor Sustain Trails (2 bugs)
This pull request fixes two bugs:
Note Sustain Trails getting cut/inverted when is downscroll enabled
| Before | After |
|---|---|
Incorrect Sustain Trails origin note (based on ghost note)
| Before | After |
|---|---|
Hope this gets added soon =D
i got one of these problems before, tysm
the Incorrect Sustain Trails origin note has actually been bothering me for a while, this is cool :)
Approving because this does fix stuff, but currently Downscroll on chart editor doesn't fully work as intended (It's supposed to flip the note grid vertically and scroll upwards, I never properly implemented that which is why it's grayed out in the editor).
Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?
Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?
Ah that explains it! We can leave flipY = true in place for now until I get around to making downscroll work.