Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

[BUG] (Charting State) Loading a song without difficulty/variation behaves unexpecfully or crashes

Open gamerbross opened this issue 9 months ago • 1 comments

If you had loaded previously a song with another variation (like Erect) or difficulty and then try to load a dfifferent song unexpectedly changes song data or crashes. (I think only crashes with song templates)

This could be easily fixed by resetting the variation and difficulty when loading a different song.

Video example: (using song template)

https://github.com/FunkinCrew/Funkin/assets/55158797/af376573-099d-4044-b609-f9dc24ac16d0

Video example: (loading existing chart)

https://github.com/FunkinCrew/Funkin/assets/55158797/a24ae89c-152f-4f76-bd9b-8a57d6d7d074

gamerbross avatar May 11 '24 23:05 gamerbross

nice catch!

amyspark-ng avatar May 12 '24 04:05 amyspark-ng

0.4.0 and still has not been fixed

NotHyper-474 avatar Jun 08 '24 23:06 NotHyper-474

Does this still happen in v0.5.1?

AbnormalPoof avatar Oct 09 '24 13:10 AbnormalPoof

Does this still happen in v0.5.1?

Yes, and can be replicated if you open a song without a Pico variation as well.

[lime.utils.Assets] ERROR: There is no BINARY asset with an ID of "songs:assets/songs/tutorial/Inst-pico.ogg"
  in lime/utils/Log.hx#37
  in lime/utils/Assets.hx#138
  in lime/utils/Assets.hx#169
  in openfl/utils/Assets.hx#135
  in funkin/Assets.hx#29
  in funkin/ui/debug/charting/handlers/ChartEditorAudioHandler.hx#105
  in funkin/ui/debug/charting/handlers/ChartEditorImportExportHandler.hx#73
  in funkin/ui/debug/charting/dialogs/ChartEditorWelcomeDialog.hx#162
  in haxe/ui/util/EventMap.hx#90
  in haxe/ui/backend/ComponentBase.hx#441
  in haxe/ui/backend/flixel/MouseHelper.hx#201
  in haxe/ui/backend/flixel/MouseHelper.hx#191
  in haxe/ui/backend/flixel/MouseHelper.hx#173
  in haxe/ui/backend/flixel/MouseHelper.hx#103

NotHyper-474 avatar Oct 10 '24 21:10 NotHyper-474

Partial duplicate of #2411

NotHyper-474 avatar Oct 25 '24 13:10 NotHyper-474