Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Bug Report: Pressing Chart key while in chart editor playtest resets your chart progress (fix included)

Open VMan-2002 opened this issue 9 months ago • 1 comments

blah blah default issue template is bloat for this

How to reproduce the bug:

  • When in chart editor, select [Test -> Playtest Chart] (Enter)
  • Press Chart key in playstate
  • Damn

How to fix: Replace this in PlayState around line 2550

    if (controls.DEBUG_CHART)
    {
      disableKeys = true;
      persistentUpdate = false;
      FlxG.switchState(() -> new ChartEditorState(
        {
          targetSongId: currentSong.id,
        }));
    }

with this

    if (controls.DEBUG_CHART)
    {
      disableKeys = true;
      persistentUpdate = false;
      if (isChartingMode)
      {
        if (FlxG.sound.music != null) FlxG.sound.music.pause(); // Don't reset song position!
        close(); // This only works because PlayState is a substate!
        return;
      }
      FlxG.switchState(() -> new ChartEditorState(
        {
          targetSongId: currentSong.id,
        }));
    }

VMan-2002 avatar May 11 '24 07:05 VMan-2002

This was fixed already i think, https://github.com/FunkinCrew/Funkin/commit/34a6e16385d18fe5a70e67ddbc0d7ec4136de34e

amyspark-ng avatar May 11 '24 14:05 amyspark-ng

This was fixed once, reverted, and then fixed again. It's still fixed in 0.5.0, so we can close this issue.

Hundrec avatar Sep 27 '24 01:09 Hundrec