Funkin
Funkin copied to clipboard
FunkinCrew
[FEATURE] Scroll Speed Event
https://github.com/FunkinCrew/Funkin/assets/107233412/d0626047-9dad-4ac7-8e01-3ced7b20f69f
What this PR does is implement a new event that sets the current scroll speed. As well as a public scrollSpeed variable in Strumline. Without adding any sustain-related rendering issues.
This PR also adds a parentStrumline variable to SustainTrail, and a way for it to redraw once the scroll speed changes.
https://github.com/FunkinCrew/Funkin/assets/107233412/8b5fe4d9-e78b-4000-afc0-7cb744b5d234
The event can also affect either strumline, an example of this is the video above!
This event can also set the base scroll directly instead of acting as a multiplier (disabled by default)!
Setting the value to 1 with Absolute disabled will set the speed to the default. (important)
PS; i ACTUALLY tested it this time
Converted to draft in order to add an extra cool feature. Changing the speed of a single strumline!
shouldn't it be just to set the new scroll speed? i think that'd be nicer...
shouldn't it be just to set the new scroll speed? i think that'd be nicer...
Noted, making changes right now
this is pretty awesome ! Gonna ping @EliteMasterEric for his thoughts on how it's implemented code wise, but def something we can use in places ! Thanks!
this is pretty awesome ! Gonna ping @EliteMasterEric for his thoughts on how it's implemented code wise, but def something we can use in places ! Thanks!
Thank you!
Once I can check the code more thoroughly I can give more feedback, but I like this in general.
Have you tried seeing how it reacts visually when changing scroll speed while notes are visible? The tween should keep it from glitching but I'm curious how it looks.
Also, 1.0 should reset to the base scroll speed, not 0.0.
Maybe there could also be an absolute checkbox (unchecked by default) that sets the value rather than applying a multiplier?
Once I can check the code more thoroughly I can give more feedback, but I like this in general.
Have you tried seeing how it reacts visually when changing scroll speed while notes are visible? The tween should keep it from glitching but I'm curious how it looks.
Also, 1.0 should reset to the base scroll speed, not 0.0.
Maybe there could also be an absolute checkbox (unchecked by default) that sets the value rather than applying a multiplier?
Sounds like good ideas, i'll try to put them in, unrelated but in it's current state the event sets the absolute speed, I will add multiplication tho as it seems easy to do on paper.
@EliteMasterEric once ur able to check the code could you make sure to tell me if theres anything wrong
I've been busy with other tasks lately, I will definitely look into reviewing it soon-ish!
If it looks good and doesn't have any problematic bugs, I will try to merge it to have it available for the next content update.
I've been busy with other tasks lately, I will definitely look into reviewing it soon-ish!
If it looks good and doesn't have any problematic bugs, I will try to merge it to have it available for the next content update.
Alr!