Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Polish for the transition from GameOverSubState back into PlayState.

Open ImCodist opened this issue 9 months ago • 1 comments

When retrying from the GameOverSubState the current implementation has some issues due to being a sub state now. This PR attempts to fix those issues.

Things that are altered:

  • The "vwoosh" transition is removed from game overs.
  • Notes are cleaned before entering the sub state, fixing a flicker effect while the black fade out is playing.
  • The health bar (and its icons) no longer lerp back to the default value upon returning to PlayState.
  • The score is no longer retained for one frame.

The way this is done is admittedly a little hacky, but is (what i believe to be) the best way around it without making any major alterations to the code. (Scary)

I am unsure if the vwoosh transition and the health bar lerp is intended when retrying a song through the GameOverSubState. So those changes are subjective. Completely understand if this isn't merged due to my lack of information on that regard.

Heres a before and after video:

https://github.com/FunkinCrew/Funkin/assets/50346006/52a36d30-abf1-4ca0-bd85-0b19bd609dde

ImCodist avatar May 09 '24 05:05 ImCodist

hi codist

Raltyro avatar May 09 '24 06:05 Raltyro