Funkin
Funkin copied to clipboard
FunkinCrew
fix focuscamera CLASSIC breaking zooms and snapping
When using Classic on FocusCamera, you have to place any zooms AFTER it, because it breaks them. It also snaps the camera, creating for jerky movement when having to use many Classic camera movements This fixes that behaviour
might update to add "Reset Camera" to the Focus Camera event schema. You might also want tweens to not reset for fast camera focuses, too, to prevent jerky movements.
nevermind tweens dont even call Reset Camera until after the tween is done unless its instant what the FUUCK classic seems like it was just an oversight more than anything, then?? Still noticed an error though, so gonna fix that rq
Me and Fabs reviewed this and concluded that the camera zooms work fine without this change. If you want to post the chart you're using and a before/after then that would help with review.
Me and Fabs reviewed this and concluded that the camera zooms work fine without this change. If you want to post the chart you're using and a before/after then that would help with review.
Oh yeah hold on lemme get a video of it I was running into the issue when porting B-Sides Stress
https://github.com/FunkinCrew/Funkin/assets/12458328/2bc0464f-091c-49b8-8af8-9fd7af5514b2
As the camera switching becomes faster, you can see it snap. It looks really bad, imo, and forces me to use an ease style when I'd want to use classic.
And here's the after:
https://github.com/FunkinCrew/Funkin/assets/12458328/4b41698e-5475-4748-a7d1-c2ce4a1fc93f
OH YEAH also fixes a bug where camera focuses cancel camera zooms, like this (just a test on DadBattle)
Before:
https://github.com/FunkinCrew/Funkin/assets/12458328/95228810-e598-4fc9-9b41-b756df616180
After:
https://github.com/FunkinCrew/Funkin/assets/12458328/905cbcde-8377-44ca-aca9-57c8e387ea81
(Also shows the Classic snap) Chart: dadbattle-chart.json
Maybe it's time for a merge? It was long enough that I didn’t even find it when I made my fix
(Coming back to this to point out the issue this fixes can be seen in 0.5.0 with Erect Cocoa!)
