Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Add a new param for the new stuff so it doesn't crash

Open Cheemsandfriends opened this issue 3 years ago • 5 comments

Polymod added some new stuff and inserted on the haxelib, The case is that it may crash without the frameworkParams This PR just adds it

Cheemsandfriends avatar Nov 23 '21 21:11 Cheemsandfriends

i dont really think this is necessary because the bug was already fixed in a pr by mastereric

AbnormalPoof avatar Nov 25 '21 04:11 AbnormalPoof

i dont really think this is necessary because the bug was already fixed in a pr by mastereric

It's for the mod support to work, And also that (At least on my HL experience) It crashes without it, And I downloaded the haxelib one but yeah. In fact, It's a current Issue that Eric knows right now and he's trying to make it optional, Not obligatory to use on Polymod.init (What I mean by optional is that it doesn't crash)

Cheemsandfriends avatar Nov 25 '21 16:11 Cheemsandfriends

The polymod init is supposed to be in the Main new func

DotWith avatar Nov 25 '21 23:11 DotWith

The polymod init is supposed to be in the Main new func

Why? If there's gonna be a polymod modding support how are you going to init? And you can use it on more places rather than Main (Because, y'know... It's a class)

Cheemsandfriends avatar Nov 26 '21 13:11 Cheemsandfriends

alr in week 7

ThePlank avatar Dec 18 '21 12:12 ThePlank