Funkin icon indicating copy to clipboard operation
Funkin copied to clipboard

Automatized dialogue txt file finder

Open MythsList opened this issue 3 years ago • 10 comments

Instead of adding your txt file path in the code, the code finds the txt file path itself.

MythsList avatar Aug 09 '21 17:08 MythsList

WHAT THE FUCK AN ACTUAL PULL REQUEST

I CANT BELIEVE THIS DOESNT MERGE KADE ENGINE OR CREATES EMPTY FILES

polybiusproxy avatar Aug 10 '21 16:08 polybiusproxy

You should use FileSystem and File to detect if the file is existing.

DotWith avatar Aug 10 '21 21:08 DotWith

You should use FileSystem and File to detect if the file is existing.

You can do a commit of my commit if you want, the code I did is just how I do stuff.

MythsList avatar Aug 10 '21 22:08 MythsList

You should use FileSystem and File to detect if the file is existing.

You can do a commit of my commit if you want, the code I did is just how I do stuff.

That sounds real stupid. You don't want ninjamuffin to get confused.

DotWith avatar Aug 11 '21 16:08 DotWith

You should use FileSystem and File to detect if the file is existing.

You can do a commit of my commit if you want, the code I did is just how I do stuff.

That sounds real stupid. You don't want ninjamuffin to get confused.

I'm just lazy

MythsList avatar Aug 11 '21 18:08 MythsList

This comment was very stupid lol

Cheemsandfriends avatar Sep 06 '21 00:09 Cheemsandfriends

This is a decent PR. Ninja-muffo, get on this NOW. This is very cool.

s-zenmode avatar Oct 05 '21 00:10 s-zenmode

What would happen if the file is missing though? Wouldn't it crash for weeks other than 6?

AbnormalPoof avatar Oct 05 '21 14:10 AbnormalPoof

What would happen if the file is missing though? Wouldn't it crash for weeks other than 6?

Actually i did forget to add some more stuff like the if statements making the dialoguebox only if dialogue isnt null. You can check my engine's source code anyway if you don't know what i am saying.

MythsList avatar Oct 05 '21 15:10 MythsList

Also, if FNF were to use sys for finding dialogue, it would break HTML5 builds. And FNF is a newgrounds game after all.

I suggest making a statement to check if the song has no dialogue coded in. (DialogueBox.hx)

AbnormalPoof avatar Dec 08 '21 19:12 AbnormalPoof