jackdaw icon indicating copy to clipboard operation
jackdaw copied to clipboard

Inconsistent assign-all api

Open kidpollo opened this issue 6 years ago • 1 comments

All other client fn's that expect a topic expect topic metadata. This fn expects a topic name string. I thing it should extract the name from the metadata as other fn's do."

As assing-all might already be used be sure to add a deprecation warning.

kidpollo avatar Feb 15 '19 19:02 kidpollo

Othe fn's into client namespace like partitions-for and seek-to-timestamp that take topic config.

Its odd that for those fns I am just passing the topic config where in the case of assign all I need to pre process my topic-config collection to extract the name like

(assign-all c (map :topic-name topics))

vs

(assign-all c topics)

kidpollo avatar Feb 20 '19 01:02 kidpollo