jackdaw icon indicating copy to clipboard operation
jackdaw copied to clipboard

new sliding window by time function

Open sorumehta opened this issue 1 year ago • 12 comments

Implemented sliding window functionality

sorumehta avatar May 12 '24 07:05 sorumehta

Dont forget to add tests :D https://github.com/FundingCircle/jackdaw/blob/master/test/jackdaw/streams_test.clj

kidpollo avatar May 13 '24 16:05 kidpollo

@kidpollo I have (finally) added the test. Also looked at my implementation and made some modifications. Let me know what you think

sorumehta avatar Jul 08 '24 18:07 sorumehta

It doesn't pass the tests. We are getting intermediate values from the windows. Will try suppressing those until the windows close

sorumehta avatar Jul 09 '24 03:07 sorumehta

@kidpollo This is done, tests are now passing.

sorumehta avatar Jul 09 '24 04:07 sorumehta

LGTM

@kidpollo Great, thanks! Hope it will get merged too!

sorumehta avatar Jul 10 '24 18:07 sorumehta

Any updates here? @kidpollo

sorumehta avatar Jul 19 '24 15:07 sorumehta

Unfortunately I am no longer an FC employee and have no insight on who actually runs this project :P maybe @jbropho ?

kidpollo avatar Jul 19 '24 16:07 kidpollo

@jbropho Can you review the PR?

sorumehta avatar Jul 22 '24 12:07 sorumehta

@kidpollo Anyone else you can think of for reviewing the PR?

sorumehta avatar Aug 09 '24 04:08 sorumehta

Unfortunately no. If you are super eager you could go down the list of contributor, however most dont work for FC. I feel that if this project has enough other users it should be given back to the community. Easy said ...

kidpollo avatar Aug 12 '24 17:08 kidpollo

@rads or @aprobus Can you review this PR?

sorumehta avatar Aug 13 '24 07:08 sorumehta