jackdaw icon indicating copy to clipboard operation
jackdaw copied to clipboard

Materialized without topic name

Open dacreify opened this issue 4 years ago • 2 comments

Summary

Fix for #262 by using alternate means of constructing a Materialized

Checklist

  • [x] tests
  • [x] updated CHANGELOG (the "unreleased" section)

dacreify avatar Jun 29 '20 18:06 dacreify

Codecov Report

Merging #263 into master will decrease coverage by 0.36%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   81.26%   80.89%   -0.37%     
==========================================
  Files          41       41              
  Lines        2562     2565       +3     
  Branches      149      149              
==========================================
- Hits         2082     2075       -7     
- Misses        331      341      +10     
  Partials      149      149              
Impacted Files Coverage Δ
src/jackdaw/streams/interop.clj 81.33% <83.33%> (+0.77%) :arrow_up:
src/jackdaw/serdes/edn2.clj 45.45% <0.00%> (-45.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04f654f...406bcba. Read the comment docs.

codecov[bot] avatar Jun 29 '20 18:06 codecov[bot]

LGTM

cddr avatar Jun 30 '20 12:06 cddr

Superseded by: https://github.com/FundingCircle/jackdaw/pull/335

dacreify avatar Aug 24 '22 17:08 dacreify