fx-core icon indicating copy to clipboard operation
fx-core copied to clipboard

test(solidity): test upgrade base testnet bridge contract

Open zakir-web3 opened this issue 1 year ago • 1 comments

Summary by CodeRabbit

  • New Features

    • Added baseSepolia network configuration with a custom URL and chain ID.
  • Refactor

    • Renamed FxBridgeLogicETH class to IFxBridgeLogic interface for better clarity.
    • Introduced dynamic contract name setting based on network conditions in the bridge contract tests.
  • Tests

    • Updated test suite to reflect changes in the bridge contract instantiation and usage.

zakir-web3 avatar May 22 '24 11:05 zakir-web3

Walkthrough

The updates introduce a new baseSepolia network configuration to the Hardhat setup and refactor the fx_bridge.ts test file. The refactor includes renaming a class to an interface, dynamically setting contract names, and updating method calls to reflect these changes.

Changes

Files Change Summary
solidity/hardhat.config.ts Added baseSepolia network configuration with custom URL and chain ID.
solidity/test/fx_bridge.ts Renamed FxBridgeLogicETH class to IFxBridgeLogic interface, introduced bridgeContractName, updated method calls.

🐇✨ In the realm of code, a network new, BaseSepolia joins the Hardhat crew. Interfaces rise where classes stood, Tests refined, as well they should. Contracts dance with dynamic names, In this update, progress flames. CodeRabbit cheers with joy so bright, For changes made in the coder's night. 🌙💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 22 '24 11:05 coderabbitai[bot]