FunctionLab
print selene_sdk version, add config and model file to output, add ra…
…ndom suffix to output directory name
Reference Issues/PRs
What does this implement/fix? Explain your changes.
What testing did you do to verify the changes in this PR?
Thanks Aaron for adding me to this PR, and thank you @ygliu2016 for your work on this! I've left some comments--feel free to tag me in a comment once you've updated / tested the changes based on the review, and let me know if you have any questions in the meantime. Overall it looks good! Thanks again :)
Overall it looks good!
Thanks Aaron for adding me to this PR, and thank you @ygliu2016 for your work on this! I've left some comments--feel free to tag me in a comment once you've updated / tested the changes based on the review, and let me know if you have any questions in the meantime. Overall it looks good! Thanks again :)
H, Kathy, thanks for coming back. Would you please tell me where are your comments? In which repository? Thanks.
The comments are directly in the changes you made - so if you scroll up above my comment or click 'files changed' tab you should be able to see what I wrote at the corresponding lines of code!
The comments are directly in the changes you made - so if you scroll up above my comment or click 'files changed' tab you should be able to see what I wrote at the corresponding lines of code!
I am so sorry. But I can not see you comments at repository ygliu2016/selene, branch info.
Hi @ygliu2016 , were you able to find the comments after you made the test comment? It's at https://github.com/FunctionLab/selene/pull/191/files "Files Changed" tab
No, I cannot. Unfortunately, I can only see my test comment. Can you comment directly in the code? Thanks.
Thank you very much for the comments and in fact, for your patience as well.
I think torch.backends.cudnn.deterministic = True is much slower, and that's probably why it was commented out before
