sway icon indicating copy to clipboard operation
sway copied to clipboard

Remove logic duplicatation between forc-client and sdk

Open kayagokalp opened this issue 1 year ago • 1 comments

We are already depending on sdk for some features, and for others we are re-implementing them from scratch creating two places to update for each change in fuel-core. We should make our best to re-use logic from sdk.

kayagokalp avatar Jun 28 '24 16:06 kayagokalp

@kayagokalp I know you replaced some duplicate logic as part of https://github.com/FuelLabs/sway/pull/6250, is there more? What code specifically?

sdankel avatar Sep 06 '24 22:09 sdankel

The scope of this issue maybe too wide; maybe worthwhile highlighting the duplicates here; or closing the issue for now until concrete examples/logic is defined?

zees-dev avatar Nov 14 '24 10:11 zees-dev

Examples are everywhere we construct the transaction itself, rather than using the transaction builders from SDK. So it is intentionally wide and the issue is more like a tracking one rather than a specific task.

Lately this got better as we transitioned deployment and run transactions to SDK owned builders especially with #6250 . I agree that we can close this for now and open individual parts we find later on separately

kayagokalp avatar Nov 15 '24 21:11 kayagokalp