sway icon indicating copy to clipboard operation
sway copied to clipboard

Added --bech32 flag to forc contract-id command

Open ADTmux opened this issue 1 year ago • 5 comments

Description

Issue : https://github.com/FuelLabs/sway/issues/5842

Checklist

  • [x] I have linked to any relevant issues.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • [ ] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • [x] I have requested a review from the relevant team or maintainers.

ADTmux avatar May 02 '24 02:05 ADTmux

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Amit Dave seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 02 '24 02:05 CLAassistant

working on updating docs. Please feel free to let me know if any areas need rework/update

ADTmux avatar May 02 '24 02:05 ADTmux

Also please run cargo fmt so that CI fails go away :) and make sure to run cargo build and commit the cargo.lock file since you added a depenedncy cargo.lock should be changed. But that is not commited here.

kayagokalp avatar May 02 '24 19:05 kayagokalp

@kayagokalp I did see the fact that we are generating the documentation for all forc commands in the Sway Book by running forc --help, but could I get any pointers to any past PRs (of how the html files are built), or as to how we are doing that? I want to add the --bech32 in the Sway Book.

ADTmux avatar May 04 '24 02:05 ADTmux

@kayagokalp I did see the fact that we are generating the documentation for all forc commands in the Sway Book by running forc --help, but could I get any pointers to any past PRs (of how the html files are built), or as to how we are doing that? I want to add the --bech32 in the Sway Book.

Hey, no worries about that we have a mdbook preprocessor that automatically does that. So it is done via CI not manually

kayagokalp avatar May 04 '24 02:05 kayagokalp