sway
sway copied to clipboard
Fix "Testing with Rust / Writing Tests" example
Description
The harnes.rs code that currently appears in the book seems to be out of date (it doesn't compile).
The proposed code was copied from the sway-test-rs
template.
(The Sway tutorial is very good, BTW.)
Checklist
- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
Breaking*
orNew Feature
labels where relevant. - [ ] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
- [ ] I have requested a review from the relevant team or maintainers.
⚠️ Found 5 invalid commit(s):
- refctor: config/GUI
b8c2bb2
- Merge remote-tracking branch 'upstream/dev' into config
2573c20
- Reduce warning
1cca359
- Merge remote-tracking branch 'upstream/rft/dotnet8' into config
86bab45
- 谁把我fody删了
2e9e601
Please follow the Conventional Commits format.
哎呀,无所谓的啦,我们只要squash merge就好了嘛
Qodana for .NET
942 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Redundant using directive |
🔶 Warning | 404 |
Unknown property |
🔶 Warning | 59 |
Method return value is never used (private accessibility) |
🔶 Warning | 57 |
Async method invocation without await expression |
🔶 Warning | 19 |
Possible 'System.NullReferenceException' |
🔶 Warning | 19 |
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. |
🔶 Warning | 18 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 11 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 10 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 8 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 5 |
Access to modified captured variable |
🔶 Warning | 4 |
Bitwise operation on enum is not marked by [Flags] attribute |
🔶 Warning | 4 |
Code is unreachable |
🔶 Warning | 4 |
Rider toolset and environment errors |
🔶 Warning | 4 |
Inconsistent synchronization on field |
🔶 Warning | 2 |
Type member is never used (private accessibility) |
🔶 Warning | 2 |
Redundant type declaration body |
🔶 Warning | 1 |
Local function return value is never used |
🔶 Warning | 1 |
Unused local variable |
🔶 Warning | 1 |
Use preferred namespace body style |
◽️ Notice | 77 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 77 |
Type member is never used (non-private accessibility) |
◽️ Notice | 62 |
Member can be made private (non-private accessibility) |
◽️ Notice | 17 |
RoslynAnalyzers Mark members as static |
◽️ Notice | 16 |
RoslynAnalyzers Non-constant fields should not be visible |
◽️ Notice | 11 |
Non-accessed field (non-private accessibility) |
◽️ Notice | 11 |
Some values of the enum are not processed inside 'switch' statement and are handled via default section |
◽️ Notice | 9 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 7 |
Type is never used (non-private accessibility) |
◽️ Notice | 5 |
Convert constructor into primary constructor |
◽️ Notice | 4 |
Event is never subscribed to (non-private accessibility) |
◽️ Notice | 3 |
Inline temporary variable |
◽️ Notice | 3 |
Overlapping sections |
◽️ Notice | 2 |
Unused parameter (non-private accessibility) |
◽️ Notice | 2 |
RoslynAnalyzers Do not assign a property to itself |
◽️ Notice | 1 |
Redundant 'else' keyword |
◽️ Notice | 1 |
Some values of the enum are not processed inside 'switch' statement |
◽️ Notice | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
#6918 这玩意也直接塞到全局里去吧
先合进去测试稳定性吧,要不然隔三差五冲突
在没有自动数据迁移功能之前,我反对本条 PR。
进dotnet8又不是进dev,那么紧张干什么
哪个分支也不行,这不是把 regression 带入别的 feature 了吗?
问问TaskQueueOrder方便从<string, int>改成类似于[{type},{type}]的格式么?
现在准备咋整啊)
累了,有时间再说吧
⚠️ Found 11 invalid commit(s):
- refctor: config/GUI
b8c2bb2
- Merge remote-tracking branch 'upstream/dev' into config
2573c20
- Reduce warning
1cca359
- Merge remote-tracking branch 'upstream/rft/dotnet8' into config
86bab45
- 谁把我fody删了
2e9e601
- fix build
7f472a7
- Config/Rft: Timer, InfrastOrder, DragItemIsChecked
c219b16
- rft/config: GUI
4756865
- Merge branch 'rft/dotnet8' into rft/config
0a260b6
- Merge branch 'dev' into rft/config
622bdc7
- update
4b949ea
Please follow the Conventional Commits format.
先把框架推上去,谁有时间慢慢迁移吧,没时间就不迁移了
再开新功能用新框架写
问问TaskQueueOrder方便从<string, int>改成类似于[{type},{type}]的格式么?
你如果能写旧配置到新配置的迁移就很方便
Qodana for .NET
950 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Redundant using directive |
🔶 Warning | 394 |
Unknown property |
🔶 Warning | 59 |
Method return value is never used (private accessibility) |
🔶 Warning | 57 |
Async method invocation without await expression |
🔶 Warning | 19 |
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. |
🔶 Warning | 19 |
Possible 'System.NullReferenceException' |
🔶 Warning | 19 |
Auto-property accessor is never used (non-private accessibility) |
🔶 Warning | 14 |
Usage of <inheritdoc /> is invalid |
🔶 Warning | 10 |
Auto-property accessor is never used (private accessibility) |
🔶 Warning | 8 |
Conditional access qualifier expression is known to be null or not null |
🔶 Warning | 5 |
Access to modified captured variable |
🔶 Warning | 4 |
Bitwise operation on enum is not marked by [Flags] attribute |
🔶 Warning | 4 |
Code is unreachable |
🔶 Warning | 4 |
Rider toolset and environment errors |
🔶 Warning | 4 |
Inconsistent synchronization on field |
🔶 Warning | 2 |
Type member is never used (private accessibility) |
🔶 Warning | 2 |
Redundant type declaration body |
🔶 Warning | 1 |
Local function return value is never used |
🔶 Warning | 1 |
Unused local variable |
🔶 Warning | 1 |
Type member is never used (non-private accessibility) |
◽️ Notice | 84 |
Use preferred namespace body style |
◽️ Notice | 77 |
Method return value is never used (non-private accessibility) |
◽️ Notice | 74 |
Member can be made private (non-private accessibility) |
◽️ Notice | 17 |
RoslynAnalyzers Mark members as static |
◽️ Notice | 12 |
RoslynAnalyzers Non-constant fields should not be visible |
◽️ Notice | 11 |
Non-accessed field (non-private accessibility) |
◽️ Notice | 11 |
Some values of the enum are not processed inside 'switch' statement and are handled via default section |
◽️ Notice | 9 |
Use preferred style of 'new' expression when created type is evident |
◽️ Notice | 7 |
Type is never used (non-private accessibility) |
◽️ Notice | 5 |
Convert constructor into primary constructor |
◽️ Notice | 4 |
Inline temporary variable |
◽️ Notice | 3 |
Overlapping sections |
◽️ Notice | 2 |
Event is never subscribed to (non-private accessibility) |
◽️ Notice | 2 |
Unused parameter (non-private accessibility) |
◽️ Notice | 2 |
RoslynAnalyzers Do not assign a property to itself |
◽️ Notice | 1 |
Class is never instantiated (non-private accessibility) |
◽️ Notice | 1 |
Some values of the enum are not processed inside 'switch' statement |
◽️ Notice | 1 |
☁️ View the detailed Qodana report
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
要不先重新基于dev拉个分支然后squash到那个新分支去
要不先重新基于dev拉个分支然后squash到那个新分支去
merge的时候squash merge就行吧
哦看了下好像只是加上了选项但还没把设置换到新的,那应该没什么问题
问问TaskQueueOrder方便从<string, int>改成类似于[{type},{type}]的格式么?
你如果能写旧配置到新配置的迁移就很方便
其他设置项有迁移了是么,等有空看看,最近忙的要死也是
问问TaskQueueOrder方便从<string, int>改成类似于[{type},{type}]的格式么?
你如果能写旧配置到新配置的迁移就很方便
其他设置项有迁移了是么,等有空看看,最近忙的要死也是
没迁移,也还没用上,先搭了个框架
问问TaskQueueOrder方便从<string, int>改成类似于[{type},{type}]的格式么?
你如果能写旧配置到新配置的迁移就很方便
其他设置项有迁移了是么,等有空看看,最近忙的要死也是
只迁移了 DarkMode 作为使用示例
只迁移了 DarkMode 作为使用示例
DarkMode只有作为新配置的使用示例,而没有从旧配置进行数据迁移的是么
DarkMode只有作为新配置的使用示例,而没有从旧配置进行数据迁移的是么
是,DarkMode在去年九月就实验性的挪过去了。配置迁移需要你自己判断是否需要,读一下旧的,然后写入到新的。
先合了吧,反正不影响现有代码,我很久不用Windows了也没时间改WPF了