sway icon indicating copy to clipboard operation
sway copied to clipboard

Add `std` & `core` libraries formatting job to CI

Open Braqzen opened this issue 3 years ago • 3 comments

Summary

At the moment if you take a look at CI (lib & core) it appears that the code is run through the formatter.

I have just submitted a PR which I have first run through the formatter. It looked really strange so I have checked the master branch for the standard library and the formatting is clearly not being applied there (and perhaps core as well).

Resolution: change the CI path to make the formatter run on both the core and std.

Braqzen avatar Jun 17 '22 12:06 Braqzen

Note that the above-linked jobs do not run the formatter on std or core, only build.

adlerjohn avatar Jun 17 '22 12:06 adlerjohn

@mohammadfawaz you recently did this iirc?

eureka-cpu avatar Sep 24 '22 01:09 eureka-cpu

I think this is referring to running a format checker in CI for std and core. Basically this is a CI task.

mohammadfawaz avatar Sep 24 '22 01:09 mohammadfawaz

Closing this in favour of https://github.com/FuelLabs/sway/issues/2917. #2917 has the milestone field set so i don't want to mess with that :)

mohammadfawaz avatar Oct 03 '22 20:10 mohammadfawaz