fuelup icon indicating copy to clipboard operation
fuelup copied to clipboard

Fix clobbering of process vs component vs forc

Open alfiedotwtf opened this issue 1 year ago • 4 comments

These issues were found while investigating #654.

Currently, component_name was being repurposed for multiple functions:

  • Checking whether or not the executable was published by forc
  • Checking whether or not the executable was in the store
  • Used to generate the tarball target
  • Used to generate the tarball URL
  • Used to generate the final target executable to run from the store

Each of the above was breaking in subtle ways depending on which executable was being run.

After separating out these functions based on the properly resolved component from the executable, and along with the previous commits, these problems above were resolved.

alfiedotwtf avatar Oct 04 '24 08:10 alfiedotwtf

LCOV of commit 7329e4e during CI #2088

Summary coverage rate:
  lines......: 85.6% (2457 of 2872 lines)
  functions..: 46.1% (382 of 829 functions)
  branches...: 63.1% (289 of 458 branches)

Files changed coverage rate: n/a

fuel-service-user avatar Oct 04 '24 08:10 fuel-service-user

Can we add some tests to show how this change works?

JoshuaBatty avatar Oct 29 '24 01:10 JoshuaBatty

Can we add some tests to show how this change works?

Yep, no problem.

alfiedotwtf avatar Oct 29 '24 01:10 alfiedotwtf

Keeping this PR in DRAFT but backgrounding for now...

90% of the tests have been done, I just have to do the other 90%. Backgrounding for now, but will leave this as a downtime task to complete.

alfiedotwtf avatar Nov 14 '24 02:11 alfiedotwtf