fuels-ts icon indicating copy to clipboard operation
fuels-ts copied to clipboard

chore: re-enable dev connector in `create-fuels` template

Open Dhaiwat10 opened this issue 1 year ago • 4 comments

Closes #2171

I know... another one-line PR 🤷🏻

Dhaiwat10 avatar Apr 30 '24 13:04 Dhaiwat10

The relationship between fuels and @fuels/connectors looks problematic.

Because one depends on the other, their cyclic dependency should always hunt us and delay releases.

arboleya avatar Apr 30 '24 17:04 arboleya

Coverage Report:

Lines Branches Functions Statements
79.53%(+0%) 69.28%(+0%) 77.43%(+0%) 79.65%(+0%)
Changed Files:

Coverage values did not change👌.

github-actions[bot] avatar May 06 '24 14:05 github-actions[bot]

The relationship between fuels and @fuels/connectors looks problematic.

Because one depends on the other, their cyclic dependency should always hunt us and delay releases.

You are right here.

I suppose we have a number of options:

  1. Install the dependency + integrate on bootstrap (not sure how viable this is).
  2. Remove the @fuels/connectors dependency entirely.
  3. Move templates to a new repository (possibly with create-fuels).

Any others that I've missed?


I'd say that after #2170 has been completed, we'll be in a better position to gauge whether option 1 is viable.

petertonysmith94 avatar May 08 '24 11:05 petertonysmith94

I just checked. There is indeed a version mis-match here. Marking this as blocked until the wallet SDK bumps their TS SDK version

Dhaiwat10 avatar May 09 '24 12:05 Dhaiwat10

Coverage Report:

Lines Branches Functions Statements
46.35%(+0%) 39.58%(+0%) 43.51%(+0%) 46.17%(+0%)
Changed Files:

Coverage values did not change👌.

github-actions[bot] avatar Jun 04 '24 14:06 github-actions[bot]