fuels-rs icon indicating copy to clipboard operation
fuels-rs copied to clipboard

Published 20 hours ago • verified publisher icon FuelLabs

feat: encryp wallet with name(address) api.

Open mtroym opened this issue 11 months ago • 4 comments

Checklist

  • [x] I have linked to any relevant issues.
  • [x] I have updated the documentation.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added necessary labels.
  • [x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • [x] I have requested a review from the relevant team or maintainers.

mtroym avatar Mar 03 '24 09:03 mtroym

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 03 '24 09:03 CLAassistant

hereby invite @digorithm @iqdecay @hal3e to review my pr. thanks.

mtroym avatar Mar 03 '24 10:03 mtroym

I would suggest you move the name parameter to the existing encrypt method. Also I would remove the test since it's just a wrapper for eth_keystore::encrypt_key

MujkicA avatar Mar 13 '24 20:03 MujkicA

I would suggest you move the name parameter to the existing encrypt method. Also I would remove the test since it's just a wrapper for eth_keystore::encrypt_key

Great, will update later. thanks.

mtroym avatar Mar 15 '24 17:03 mtroym