fuel-specs icon indicating copy to clipboard operation
fuel-specs copied to clipboard

Consider adding `GTF_OUTPUT_VARIABLE_AMOUNT` and `GTF_OUTPUT_CHANGE_AMOUNT` fields to `gtf`

Open mohammadfawaz opened this issue 2 years ago • 3 comments

Consider adding GTF_OUTPUT_VARIABLE_AMOUNT and GTF_OUTPUT_CHANGE_AMOUNT fields to gtf. A field for OutputChange may be redundant because the value is always 0, but it's worth considering adding it just for completeness.

mohammadfawaz avatar Aug 30 '22 20:08 mohammadfawaz

cc @vlopes11

Voxelot avatar Aug 30 '22 21:08 Voxelot

It could also be helpful to include an _AMOUNT, _ASSET_ID and _TO for OutputChange and OutputVariable for completeness. The bridge predicate already has a use case to check for GTF_OUTPUT_CHANGE_ASSET_ID

pixelcircuits avatar Sep 04 '22 04:09 pixelcircuits

Given change amounts are only set post-execution, I'm not sure if there's a real use case for GTF_OUTPUT_CHANGE_AMOUNT.

Voxelot avatar Sep 06 '22 23:09 Voxelot

I think it is better not to support useless GTF, because it only increases the codebase burden and adds confusion to the user, which expects an actual value.

If we still want to do that, then we can reopen this issue and continue discussion again

xgreenx avatar May 26 '23 12:05 xgreenx