fuel-core icon indicating copy to clipboard operation
fuel-core copied to clipboard

Published 20 hours ago • verified publisher icon FuelLabs

chore: Reviewed Imports

Open ch1n3du opened this issue 2 years ago • 2 comments

I've been able to format most of the imports but I think I caused a lifetime error in fuel-core in fuel-core/src/schema/dap.rs line 445 and 469 and in fuel-core/src/schema/message.rs line 17 not really sure how to fix it and would love any help. #537

ch1n3du avatar Aug 19 '22 20:08 ch1n3du

@Ch1n3du looks like there are still some importing and other compilation errors, let me know if you need help fixing them

ControlCplusControlV avatar Aug 20 '22 17:08 ControlCplusControlV

@Ch1n3du looks like there are still some importing and other compilation errors, let me know if you need help fixing them

Sorry for not replying sooner, I fell ill but I highlighted the issues I was having at the top of the pr, not really sure how to solve them as they have to do with lifetimes and a proc macro I can't figure out

ch1n3du avatar Aug 23 '22 16:08 ch1n3du

Hmm, I think we already did it with new rustfmt rules https://github.com/FuelLabs/fuel-core/pull/575 and https://github.com/FuelLabs/fuel-core/pull/605

xgreenx avatar Sep 13 '22 01:09 xgreenx

Thanks for the PR, but as @xgreenx has mentioned we've largely automated this via nightly rustfmt features.

Voxelot avatar Sep 14 '22 19:09 Voxelot