fuel-core icon indicating copy to clipboard operation
fuel-core copied to clipboard

replace usage of surf with lighter-weight http-client

Open Voxelot opened this issue 2 years ago • 4 comments

surf is bloated with an unmaintained dependency graph containing many security warnings. We should replace it with a lighter-weight solution such as reqwest or hyper.

It should also use rustls or some other non-openssl dependency.

Voxelot avatar Apr 27 '22 17:04 Voxelot

We can't migrate to reqwest since openssl dependencies are being enabled by the graphql client extension framework cynic. Once they release this pr (https://github.com/obmarg/cynic/pull/411), we'll be able to use reqwest without depending on openssl.

Voxelot avatar Apr 29 '22 15:04 Voxelot

@Voxelot Cynic seems to be taking its sweet time releasing v2. Would it be worth it to fork it and release a forked cynic we can use ourselves?

adlerjohn avatar May 28 '22 17:05 adlerjohn

Cynic is composed of many libraries, so an alternative is to only use its querygen crate, and wrap it with our own HTTP client.

Voxelot avatar May 31 '22 17:05 Voxelot

Note: https://github.com/http-rs/http-client/issues/98

adlerjohn avatar Jun 18 '22 20:06 adlerjohn

@Voxelot I guess we can close this issue because of https://github.com/FuelLabs/fuel-core/pull/786 ?

xgreenx avatar Dec 02 '22 14:12 xgreenx

yep!

Voxelot avatar Dec 02 '22 23:12 Voxelot