fuel-core icon indicating copy to clipboard operation
fuel-core copied to clipboard

feat: add pending connection limits + bump libp2p to `0.54.1`

Open maschad opened this issue 1 year ago • 6 comments

Linked Issues/PRs

  • Closes https://github.com/FuelLabs/fuel-core/issues/1560
  • Closes https://github.com/FuelLabs/fuel-core/issues/904

Description

This is apart of the broader initiative outlined in https://github.com/FuelLabs/fuel-core/issues/1968 to improve the DoS resilience

Checklist

  • [x] Breaking changes are clearly marked as such in the PR description and changelog

Before requesting review

  • [x] I have reviewed the code myself

maschad avatar Sep 01 '24 21:09 maschad

Looks good to me. Little nit on the CHANGELOG. Can you update it now that you have a new parameter added ?

Good catch @AurelienFT , I've updated it in 1127c7200

maschad avatar Sep 07 '24 18:09 maschad

We shouldn't merge this PR before https://github.com/FuelLabs/fuel-core/pull/2131

Plus, let's wait for my review as well, since maybe we need to clean up some other logic

xgreenx avatar Sep 09 '24 13:09 xgreenx

How's this coming?

MitchTurner avatar Oct 17 '24 12:10 MitchTurner

How's this coming?

Thanks for resurfacing this @MitchTurner it got lost in the ether with the mainnet whirlwind of changes.

I've resolved the conflicts so it's ready for review again. I know @xgreenx wanted to look into it again but the changes imo are relatively low surface - I've upgraded our libp2p version + introduced connection limit options.

maschad avatar Oct 21 '24 17:10 maschad

Hello @maschad,

As you mentionned that @xgreenx wanted to look again we will wait him before merging this but I can already re-approve as a first approver. However before approving the conflicts should be resolved, are you ok to resolve them ? Or we can do it for you, if you prefer :)

Thanks again for this PR.

AurelienFT avatar Oct 29 '24 10:10 AurelienFT

Thanks @AurelienFT I've gone ahead and resolved the conflicts.

maschad avatar Oct 29 '24 10:10 maschad

@maschad is it okay if I take over this PR? there seem to be some formatting issues

rymnc avatar Jan 08 '25 15:01 rymnc

Thanks for the contribution! Before we can merge this, we need @maschad to sign the Fuel Labs Contributor License Agreement.

fuel-cla-bot[bot] avatar Jan 28 '25 18:01 fuel-cla-bot[bot]