refactor: remove `Option<BlockHeight>` and use new enum where applicable

[matt-user]

closes #2005

I replaced Option<BlockHeight> with BlockHeightQuery where applicable. IIUC there are Option<BlockHeight> which should remain.

Checklist

• [X] Breaking changes are clearly marked as such in the PR description and changelog
• [X] New behavior is reflected in tests
• [X] The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

• [X] I have reviewed the code myself
• [ ] I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

• [ ] Rust SDK
• [ ] Sway compiler
• [ ] Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
• [ ] Someone else?

[rymnc]

@matt-user / @MitchTurner can I just regen the state transition bytecode, run tests again and then merge?

[MitchTurner]

Ah dang. Sorry @matt-user I thought this got merged :o

[AurelienFT]

Hello @matt-user ,

Sorry for letting your PR became stale like this. Are you ok to resolve the conflicts so that we can gett this merge soonish ? If you prefer we can take care of the conflicts for you, let me know :) Sorry again.

[matt-user]

Hello @matt-user ,

Sorry for letting your PR became stale like this. Are you ok to resolve the conflicts so that we can gett this merge soonish ? If you prefer we can take care of the conflicts for you, let me know :) Sorry again.

Yeah sorry, I completely forgot about this. I will resolve the conflicts